Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aio): pngcrush all pngs #18243

Closed
wants to merge 648 commits into from

Conversation

Projects
None yet
@jelbourn
Copy link
Member

jelbourn commented Jul 20, 2017

This is the result of running

find ./ -iname "*.png" -exec pngcrush -brute -ow --  {} \;

Resulting filesize difference

Most of the improvements are pretty small, but there are a few good reductions (122 kb on one image!)

alexeagle and others added some commits Jun 22, 2017

ci: test merge commits on circle
We expect this behavior because it's what Travis does. Also it's better because we want
to test what happens if we merge the PR, not the status of the PR branch.
fix(aio): preserve newlines when copying code
Before 4f37f86, we were using `innerText` to retrieved the code content for
copying. This preserved the text layout (including newlines), but suffered from
other issues (browser support, performance). With 4f37f86 we switched to
`textContent`, which works well except in the following case:
When `prettify` formats the code to have line numbers, it removes the newlines
and uses `<li>` elements instead. This affects `textContent`.

This commit fixes this by keeping a reference of the code as text and using that
for copying.

Fixes #17659
fix(aio): prefix `location.assign` with `window.`
No practical effect but clears the TS compiler warning.
feat(aio): enable previews for any PR
This commit introduces the ability to show previews for PRs by any author. It works as follows:

- The build artifacts of all PRs are uploaded to the preview server.
- Automatically verified PRs (i.e. from trusted authors or having a specific label) are deployed and
  publicly accessible as usual.
- PRs that could not be automatically verified are stored for later use (after re-verification).
- A PR can be marked as "trusted" and make its preview publicly accessible by adding the GitHub
  label specified in the `AIO_TRUSTED_PR_LABEL` env var of the preview server.

At the moment, there is no automatic mechanism for notifying the preview server about changes to the
PR's verification status. The PR's "visibility" will be checked and updated every time a new build
is uploaded.
ci(aio): deploy previews for all PRs
PRs that could not be automatically verified will not be publicly accessible,
until manually verified.
ci(aio): upload aio payload size to firebase
ci(aio): Add timestamp and change data
refactor(compiler): add tracking comment for self-import detection
The underlying cause of #17386 needs to be investigated and as a
simple string compare should have been valid.

matsko and others added some commits Jul 17, 2017

fix(animations): make sure @.disabled works in non-animation components
Note 4.3 only!

Prior to this fix when [@.disabled] was used in a component that
contained zero animation code it wouldn't register properly because the
renderer associated with that component was not an animation renderer.
This patch ensures that it gets registered even when there are no
animations set.
docs(aio): fix typo in Router documentation
Fix title and link to RouteConfigLoadEnd documentation

@jelbourn jelbourn requested a review from IgorMinar Jul 20, 2017

@googlebot googlebot added the cla: yes label Jul 20, 2017

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Jul 20, 2017

@jelbourn jelbourn requested a review from petebacondarwin Jul 20, 2017

@petebacondarwin

This comment has been minimized.

Copy link
Member

petebacondarwin commented Jul 20, 2017

The Travis fail is a core e2e test flake and nothing to do with this PR.

@mhevery mhevery force-pushed the angular:master branch from 08b36cb to 5d4b36f Jul 20, 2017

@mhevery mhevery closed this in 1bfc77b Jul 20, 2017

mhevery added a commit that referenced this pull request Jul 26, 2017

asnowwolf added a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017

juleskremer added a commit to juleskremer/angular that referenced this pull request Aug 26, 2017

juleskremer added a commit to juleskremer/angular that referenced this pull request Aug 28, 2017

jelbourn added a commit to jelbourn/angular that referenced this pull request Jan 31, 2019

perf: pngcrush all pngs
This is the result of running
```sh
find ./ -iname "*.png" -exec pngcrush -brute -ow --  {} \;
```

[Summary of size reductions](https://docs.google.com/spreadsheets/d/12Qgx7DfKabWw0PJza6ozC1kCHTofi6wyBLWGtwLW7G4/preview)

Last done in July, 2017 in angular#18243

@jelbourn jelbourn referenced this pull request Jan 31, 2019

Closed

perf: pngcrush all pngs #28479

matsko added a commit that referenced this pull request Feb 1, 2019

perf: pngcrush all pngs (#28479)
This is the result of running
```sh
find ./ -iname "*.png" -exec pngcrush -brute -ow --  {} \;
```

[Summary of size reductions](https://docs.google.com/spreadsheets/d/12Qgx7DfKabWw0PJza6ozC1kCHTofi6wyBLWGtwLW7G4/preview)

Last done in July, 2017 in #18243

PR Close #28479

matsko added a commit that referenced this pull request Feb 1, 2019

perf: pngcrush all pngs (#28479)
This is the result of running
```sh
find ./ -iname "*.png" -exec pngcrush -brute -ow --  {} \;
```

[Summary of size reductions](https://docs.google.com/spreadsheets/d/12Qgx7DfKabWw0PJza6ozC1kCHTofi6wyBLWGtwLW7G4/preview)

Last done in July, 2017 in #18243

PR Close #28479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.