Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split compiler and core #18683

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
5 participants
@tbosch
Copy link
Member

commented Aug 14, 2017

Note: The first 4 commits are from #18720

@mary-poppins

This comment has been minimized.

Copy link

commented Aug 14, 2017

@tbosch tbosch force-pushed the tbosch:compiler_no_core branch from 1e57ea0 to 0aefd15 Aug 16, 2017

@tbosch tbosch changed the title WIP: Split compiler and core Split compiler and core Aug 16, 2017

@tbosch tbosch force-pushed the tbosch:compiler_no_core branch from 0aefd15 to f422a63 Aug 16, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Aug 16, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Aug 16, 2017

this._registerDecoratorOrConstructor(
this.findDeclaration(ANGULAR_CORE, 'Component'), Component);
this._registerDecoratorOrConstructor(this.findDeclaration(ANGULAR_CORE, 'NgModule'), NgModule);
this._registerDecoratorOrConstructor(MetadataIdentifier.Host, createHost);

This comment has been minimized.

Copy link
@chuckjaz

chuckjaz Aug 16, 2017

Member

As discussed offline, I don't believe MetadataIdentifer is required.

@@ -0,0 +1,149 @@
/**

This comment has been minimized.

Copy link
@chuckjaz

chuckjaz Aug 16, 2017

Member

Consider moving the reflect_metadata requirement to this module so we no longer require it in compiler.

This comment has been minimized.

Copy link
@tbosch

tbosch Aug 16, 2017

Author Member

I would like to postpone this to another PR...

@tbosch tbosch force-pushed the tbosch:compiler_no_core branch from f422a63 to c1e5781 Aug 16, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Aug 16, 2017

@tbosch tbosch force-pushed the tbosch:compiler_no_core branch from c1e5781 to cbdafd2 Aug 16, 2017

@tbosch tbosch removed the PR state: WIP label Aug 16, 2017

@tbosch tbosch force-pushed the tbosch:compiler_no_core branch from cbdafd2 to 20d14e2 Aug 16, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Aug 16, 2017

@tbosch tbosch force-pushed the tbosch:compiler_no_core branch from 20d14e2 to b4bc466 Aug 16, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Aug 16, 2017

tbosch added some commits Aug 10, 2017

refactor(compiler): split compiler and core
After this, neither @angular/compiler nor @angular/comnpiler-cli depend
on @angular/core.

This add a duplication of some interfaces and enums which is stored
in @angular/compiler/src/core.ts

BREAKING CHANGE:
- `@angular/platform-server` now additionally depends on
  `@angular/platform-browser-dynamic` as a peer dependency.

@tbosch tbosch force-pushed the tbosch:compiler_no_core branch from b4bc466 to 40754da Aug 16, 2017

@tbosch

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2017

Note: This was already green, CI only runs because of another rebase.

@mary-poppins

This comment has been minimized.

Copy link

commented Aug 16, 2017

mhevery added a commit that referenced this pull request Aug 17, 2017

@mhevery mhevery closed this in 0cc77b4 Aug 17, 2017

@tbosch tbosch deleted the tbosch:compiler_no_core branch Aug 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.