New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): allow multiple exportAs names #18723

Merged
merged 1 commit into from Aug 16, 2017

Conversation

Projects
None yet
5 participants
@jelbourn
Member

jelbourn commented Aug 16, 2017

This change allows users to specify multiple exportAs names for a
directive by giving a comma-delimited list inside the string.

The primary motivation for this change is to allow these names to be
changed in a backwards compatible way.

I chatted w/ @mhevery and @vicb who agreed that this seemed a reasonable change

cc @andrewseguin

feat(compiler): allow multiple exportAs names
This change allows users to specify multiple exportAs names for a
directive by giving a comma-delimited list inside the string.

The primary motivation for this change is to allow these names to be
changed in a backwards compatible way.

@jelbourn jelbourn requested review from vicb and tbosch Aug 16, 2017

@googlebot googlebot added the cla: yes label Aug 16, 2017

@jelbourn jelbourn changed the title from feat(core): allow multiple exportAs names to feat(compiler): allow multiple exportAs names Aug 16, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Aug 16, 2017

@tbosch

tbosch approved these changes Aug 16, 2017

LGTM once travis is green.

@jelbourn

This comment has been minimized.

Show comment
Hide comment
@jelbourn

jelbourn Aug 16, 2017

Member

Travis is green; it was just a SauceLabs timeout

Member

jelbourn commented Aug 16, 2017

Travis is green; it was just a SauceLabs timeout

@hansl

This comment has been minimized.

Show comment
Hide comment
@hansl

hansl Aug 16, 2017

Contributor

@jelbourn Just want to confirm; this should only be in master, correct?

Contributor

hansl commented Aug 16, 2017

@jelbourn Just want to confirm; this should only be in master, correct?

@jelbourn

This comment has been minimized.

Show comment
Hide comment
@jelbourn

jelbourn Aug 16, 2017

Member

@hansl yes, only for v5

Member

jelbourn commented Aug 16, 2017

@hansl yes, only for v5

@hansl hansl merged commit 3a50098 into angular:master Aug 16, 2017

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
code-review/pullapprove Approved by all reviewer groups.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

mhevery added a commit that referenced this pull request Sep 1, 2017

feat(compiler): allow multiple exportAs names (#18723)
This change allows users to specify multiple exportAs names for a
directive by giving a comma-delimited list inside the string.

The primary motivation for this change is to allow these names to be
changed in a backwards compatible way.

PR Close #18723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment