New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): set `enableLegacyTemplate` to false by default #18756

Closed
wants to merge 1 commit into
base: master
from

Conversation

@ocombe
Contributor

ocombe commented Aug 17, 2017

PR Type

What kind of change does this PR introduce?

[x] Feature

What is the current behavior?

The compiler option enableLegacyTemplate is enabled by default

What is the new behavior?

The compiler option enableLegacyTemplate is now disabled by default as <template> elements have been deprecated since v4. Use <ng-template> instead.

Does this PR introduce a breaking change?

[x] Yes
@vicb

vicb approved these changes Aug 17, 2017

Please add a note in the commit message that this seeting will be removed in v6.

@angular angular deleted a comment from mary-poppins Aug 18, 2017

@angular angular deleted a comment from mary-poppins Aug 18, 2017

@angular angular deleted a comment from mary-poppins Aug 22, 2017

@angular angular deleted a comment from mary-poppins Aug 22, 2017

@ocombe

This comment has been minimized.

Show comment
Hide comment
@ocombe

ocombe Aug 22, 2017

Contributor

@juleskremer can you validate the changes in the structural directives guide/examples please? https://pr18756-72287eb.ngbuilds.io/guide/structural-directives

Contributor

ocombe commented Aug 22, 2017

@juleskremer can you validate the changes in the structural directives guide/examples please? https://pr18756-72287eb.ngbuilds.io/guide/structural-directives

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Aug 22, 2017

@angular angular deleted a comment from mary-poppins Aug 22, 2017

@@ -208,17 +208,7 @@ Here is `*ngIf` displaying the hero's name if `hero` exists.
The asterisk is "syntactic sugar" for something a bit more complicated.
Internally, Angular desugars it in two stages.

This comment has been minimized.

@vicb

vicb Aug 22, 2017

Contributor

sounds wrong.

I agree we should remove the "desugars it in two stages." it is wrong.

@vicb

vicb Aug 22, 2017

Contributor

sounds wrong.

I agree we should remove the "desugars it in two stages." it is wrong.

@vicb

This comment has been minimized.

Show comment
Hide comment
@vicb

vicb Aug 22, 2017

Contributor

Agree with the code changes.

Not sure about the aio changes:

  • added some comments in the PR,
  • image resolution looks very different, is this expected ?
Contributor

vicb commented Aug 22, 2017

Agree with the code changes.

Not sure about the aio changes:

  • added some comments in the PR,
  • image resolution looks very different, is this expected ?
@juleskremer

LGTM with Vic changes; also, we need to check the sizing on the images.

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Aug 23, 2017

@vicb

vicb approved these changes Aug 28, 2017

@IgorMinar

Can we change this to a "feat" rather than "refactor" - since we are changing the behavior, we should not claim that this change is a refactor. refactorings should have no visible impact for external developers.

@ocombe ocombe changed the title from refactor(compiler): set `enableLegacyTemplate` to false by default to feat(compiler): set `enableLegacyTemplate` to false by default Aug 28, 2017

@ocombe

This comment has been minimized.

Show comment
Hide comment
@ocombe

ocombe Aug 28, 2017

Contributor

@IgorMinar done

Contributor

ocombe commented Aug 28, 2017

@IgorMinar done

@jasonaden

This comment has been minimized.

Show comment
Hide comment
@jasonaden

jasonaden Aug 29, 2017

Contributor

@ocombe Please have this pass Travis, then we can merge.

Contributor

jasonaden commented Aug 29, 2017

@ocombe Please have this pass Travis, then we can merge.

feat(compiler): set `enableLegacyTemplate` to false by default
BREAKING CHANGE: the compiler option `enableLegacyTemplate` is now disabled by default as the `<template>` element has been deprecated since v4. Use `<ng-template>` instead. The option `enableLegacyTemplate` and the `<template>` element will both be removed in Angular v6.
@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Aug 29, 2017

@jasonaden jasonaden closed this in 56238fe Sep 1, 2017

@ocombe ocombe deleted the ocombe:disable-legacy-template branch Sep 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment