Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): remove deprecated code in iterables #18757

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
5 participants
@ocombe
Copy link
Contributor

commented Aug 17, 2017

PR Type

What kind of change does this PR introduce?

[ ] Other... Please describe: removing deprecated code

What is the current behavior?

  • TrackByFn was no longer used but still exported
  • DifferFactory.create took a ChangeDetectionRef as a first argument but it was not used
  • DefaultIterableDiffer, KeyValueDiffers#factories & IterableDiffers#factories were public but were meant to be private/internal

What is the new behavior?

  • TrackByFn has been removed because it was deprecated since v4. Use TrackByFunction instead.
  • DifferFactory.create no longer takes ChangeDetectionRef as a first argument as it was not used and deprecated since v4.
  • DefaultIterableDiffer, KeyValueDiffers#factories & IterableDiffers#factories are no longer public, they have been removed from the public API as they were deprecated since v4.

Does this PR introduce a breaking change?

[x] Yes

@ocombe ocombe requested a review from vicb Aug 17, 2017

@googlebot googlebot added the cla: yes label Aug 17, 2017

@ocombe ocombe changed the title Remove deprecated code in iterables refactor(core): remove deprecated code in iterables Aug 17, 2017

@vicb

vicb approved these changes Aug 17, 2017

@ocombe ocombe force-pushed the ocombe:remove-iterable-deprecated branch from 562bfb8 to 1f0de1e Aug 17, 2017

ocombe added some commits Aug 17, 2017

refactor(core): remove deprecated `TrackByFn`
BREAKING CHANGE: `TrackByFn` has been removed because it was deprecated since v4. Use `TrackByFunction` instead.
refactor(core): remove deprecated `ChangeDetectionRef` argument in `D…
…ifferFactory#create`

BREAKING CHANGE: `DifferFactory.create` no longer takes ChangeDetectionRef as a first argument as it was not used and deprecated since v4.
refactor(core): remove deprecated core in differs
BREAKING CHANGE: `DefaultIterableDiffer`, `KeyValueDiffers#factories` & `IterableDiffers#factories` are no longer public, they have been removed from the public API as they were deprecated since v4.

@ocombe ocombe force-pushed the ocombe:remove-iterable-deprecated branch from 1f0de1e to 54abfcc Aug 18, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Aug 18, 2017

@angular angular deleted a comment from mary-poppins Aug 18, 2017

@angular angular deleted a comment from mary-poppins Aug 18, 2017

@mhevery mhevery closed this in 596e9f4 Aug 18, 2017

mhevery added a commit that referenced this pull request Aug 18, 2017

refactor(core): remove deprecated `ChangeDetectionRef` argument in `D…
…ifferFactory#create` (#18757)

BREAKING CHANGE: `DifferFactory.create` no longer takes ChangeDetectionRef as a first argument as it was not used and deprecated since v4.

PR Close #18757

@ocombe ocombe deleted the ocombe:remove-iterable-deprecated branch Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.