Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): remove deprecated parameter for `ErrorHandler` #18759

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@ocombe
Copy link
Contributor

ocombe commented Aug 17, 2017

PR Type

What kind of change does this PR introduce?

[ ] Other... Please describe: removing deprecated code

What is the current behavior?

ErrorHandler was taking a parameter but was not using it.

What is the new behavior?

ErrorHandler no longer takes a parameter as it was not used and deprecated since v4.

Does this PR introduce a breaking change?

[x] Yes
* rethrow.
*/
deprecatedParameter?: boolean) {}
constructor() {}

This comment has been minimized.

Copy link
@vicb

vicb Aug 17, 2017

Contributor

remove the ctor altogether

This comment has been minimized.

Copy link
@ocombe

ocombe Aug 17, 2017

Author Contributor

done

refactor(core): remove deprecated parameter for `ErrorHandler`
BREAKING CHANGE: `ErrorHandler` no longer takes a parameter as it was not used and deprecated since v4.

@ocombe ocombe force-pushed the ocombe:remove-error-handler-parameter branch from a49542d to 06e2ea4 Aug 17, 2017

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Aug 17, 2017

You can preview a49542d at https://pr18759-a49542d.ngbuilds.io/.

@vicb

vicb approved these changes Aug 17, 2017

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Aug 17, 2017

@mhevery mhevery closed this in 8f41326 Aug 18, 2017

@ocombe ocombe deleted the ocombe:remove-error-handler-parameter branch Aug 18, 2017

@dherges

This comment has been minimized.

Copy link
Contributor

dherges commented Nov 10, 2017

Parameter was used for whether to re-throw errors, see #15208

@ocombe

This comment has been minimized.

Copy link
Contributor Author

ocombe commented Nov 10, 2017

It was no longer used since v4, see the PR that you linked.

@dherges

This comment has been minimized.

Copy link
Contributor

dherges commented Nov 10, 2017

Yes @ocombe, since 4.0.0-rc.4 ... went completely unnoticed to me ...

It was also the only breaking change I had for migrating from v4 to v5! Cheers! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.