Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(platform-browser): remove deprecated `NgProbeToken` #18760

Closed

Conversation

Projects
None yet
5 participants
@ocombe
Copy link
Contributor

ocombe commented Aug 17, 2017

PR Type

What kind of change does this PR introduce?

[ ] Other... Please describe: removing deprecated code

What is the current behavior?

NgProbeToken had been moved to @angular/core, the one in platform-browser was no longer used.

What is the new behavior?

NgProbeToken has been removed from @angular/platform-browser as it was deprecated since v4. Import it from @angular/core instead.

Does this PR introduce a breaking change?

[x] Yes
export function _createNgProbe(extraTokens: NgProbeToken[], coreTokens: core.NgProbeToken[]): any {
const tokens = (extraTokens || []).concat(coreTokens || []);
export function _createNgProbe(coreTokens: core.NgProbeToken[]): any {
const tokens = coreTokens || [];
exportNgVar(INSPECT_GLOBAL_NAME, inspectNativeElement);
exportNgVar(CORE_TOKENS_GLOBAL_NAME, {...CORE_TOKENS, ..._ngProbeTokensToMap(tokens || [])});

This comment has been minimized.

Copy link
@vicb

vicb Aug 17, 2017

Contributor

useless default value tokens || []

This comment has been minimized.

Copy link
@ocombe

ocombe Aug 17, 2017

Author Contributor

done

@vicb
Copy link
Contributor

vicb left a comment

inline comments

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Aug 17, 2017

refactor(platform-browser): remove deprecated `NgProbeToken`
BREAKING CHANGE: `NgProbeToken` has been removed from `@angular/platform-browser` as it was deprecated since v4. Import it from `@angular/core` instead.

@ocombe ocombe force-pushed the ocombe:remove-ng-probe-token-platform-browser branch from 56986e0 to d92b6cf Aug 17, 2017

@vicb

vicb approved these changes Aug 17, 2017

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Aug 17, 2017

@mhevery mhevery closed this in d7f42bf Aug 18, 2017

@ocombe ocombe deleted the ocombe:remove-ng-probe-token-platform-browser branch Aug 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.