Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): add option to remove blank text nodes from compiled templates #18823

Conversation

pkozlowski-opensource
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource commented Aug 22, 2017

This PR retrofits WS removal code against the 4.x.

This PR cherry-picks the following commits in order to retrofit WS removal from master to 4.x:

@pkozlowski-opensource pkozlowski-opensource added PR target: patch-only action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Aug 22, 2017
@pkozlowski-opensource
Copy link
Member Author

pkozlowski-opensource commented Aug 22, 2017

ci/circleci: lint job is failing with:

INVALID COMMIT MSG: "Revert "revert: revert: ci(aio): exclude changes in aio/content folder""
=> ERROR: The commit message does not match the format of "(): OR revert: type(): "

This is not linked to this PR (guess it is failing on all the sha in this branch).

@@ -91,6 +91,10 @@ export interface CompilerOptions extends ts.CompilerOptions {

// Whether to enable support for <template> and the template attribute (true by default)
enableLegacyTemplate?: boolean;

// Whether to remove blank text nodes from compiled templates. It is `true` by default
// in Angular 5 and will be re-visited in Angular 6.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update here ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mhevery
Copy link
Contributor

mhevery commented Sep 1, 2017

Any progress on this? ETA?

@pkozlowski-opensource
Copy link
Member Author

@mhevery for me this one is ready to be reviewed / merged (as it was reviewed when landing in master). Circle CI build failing is unrelated to this issue (see #18823 (comment)).

I've aligned it with the code in master and rebased on top of 4.3x. Let me know if there is anything else I could do to help getting it in.

@vicb vicb added the action: merge The PR is ready for merge by the caretaker label Sep 1, 2017
@mhevery mhevery removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 1, 2017
mhevery pushed a commit that referenced this pull request Sep 1, 2017
@mhevery
Copy link
Contributor

mhevery commented Sep 1, 2017

merged as b8b551c

@mhevery mhevery closed this Sep 1, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants