New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): add option to remove blank text nodes from compiled templates #18823

Closed
wants to merge 1 commit into
base: 4.3.x
from

Conversation

Projects
None yet
4 participants
@pkozlowski-opensource
Member

pkozlowski-opensource commented Aug 22, 2017

This PR retrofits WS removal code against the 4.x.

This PR cherry-picks the following commits in order to retrofit WS removal from master to 4.x:

@pkozlowski-opensource

This comment has been minimized.

Show comment
Hide comment
@pkozlowski-opensource

pkozlowski-opensource Aug 22, 2017

Member

ci/circleci: lint job is failing with:

INVALID COMMIT MSG: "Revert "revert: revert: ci(aio): exclude changes in aio/content folder""
=> ERROR: The commit message does not match the format of "(): OR revert: type(): "

This is not linked to this PR (guess it is failing on all the sha in this branch).

Member

pkozlowski-opensource commented Aug 22, 2017

ci/circleci: lint job is failing with:

INVALID COMMIT MSG: "Revert "revert: revert: ci(aio): exclude changes in aio/content folder""
=> ERROR: The commit message does not match the format of "(): OR revert: type(): "

This is not linked to this PR (guess it is failing on all the sha in this branch).

@mhevery

This comment has been minimized.

Show comment
Hide comment
@mhevery

mhevery Sep 1, 2017

Member

Any progress on this? ETA?

Member

mhevery commented Sep 1, 2017

Any progress on this? ETA?

@pkozlowski-opensource

This comment has been minimized.

Show comment
Hide comment
@pkozlowski-opensource

pkozlowski-opensource Sep 1, 2017

Member

@mhevery for me this one is ready to be reviewed / merged (as it was reviewed when landing in master). Circle CI build failing is unrelated to this issue (see #18823 (comment)).

I've aligned it with the code in master and rebased on top of 4.3x. Let me know if there is anything else I could do to help getting it in.

Member

pkozlowski-opensource commented Sep 1, 2017

@mhevery for me this one is ready to be reviewed / merged (as it was reviewed when landing in master). Circle CI build failing is unrelated to this issue (see #18823 (comment)).

I've aligned it with the code in master and rebased on top of 4.3x. Let me know if there is anything else I could do to help getting it in.

@vicb

vicb approved these changes Sep 1, 2017

@mhevery

mhevery approved these changes Sep 1, 2017

mhevery added a commit that referenced this pull request Sep 1, 2017

@mhevery

This comment has been minimized.

Show comment
Hide comment
@mhevery

mhevery Sep 1, 2017

Member

merged as b8b551c

Member

mhevery commented Sep 1, 2017

merged as b8b551c

@mhevery mhevery closed this Sep 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment