New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(core): add option to remove blank text nodes from compiled templates #18823
perf(core): add option to remove blank text nodes from compiled templates #18823
Conversation
ci/circleci: lint job is failing with:
This is not linked to this PR (guess it is failing on all the sha in this branch). |
@@ -91,6 +91,10 @@ export interface CompilerOptions extends ts.CompilerOptions { | |||
|
|||
// Whether to enable support for <template> and the template attribute (true by default) | |||
enableLegacyTemplate?: boolean; | |||
|
|||
// Whether to remove blank text nodes from compiled templates. It is `true` by default | |||
// in Angular 5 and will be re-visited in Angular 6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
c75aa67
to
d576d50
Compare
Any progress on this? ETA? |
d576d50
to
6b76eac
Compare
@mhevery for me this one is ready to be reviewed / merged (as it was reviewed when landing in master). Circle CI build failing is unrelated to this issue (see #18823 (comment)). I've aligned it with the code in master and rebased on top of 4.3x. Let me know if there is anything else I could do to help getting it in. |
merged as b8b551c |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR retrofits WS removal code against the 4.x.
This PR cherry-picks the following commits in order to retrofit WS removal from master to 4.x: