Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n code refactoring (intl removal) #18907

Closed
wants to merge 6 commits into from

Conversation

Projects
None yet
6 participants
@vicb
Copy link
Contributor

commented Aug 28, 2017

This PR consists of:

  • #18868 - commit 1
  • #18857 - commit 2, 3
  • moving the locales files - commit 4, 5
  • #18813 - commit 6

Because the PR needs to be merged one after the other. Both of them got approved.

@googlebot

This comment has been minimized.

Copy link

commented Aug 28, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@mary-poppins

This comment has been minimized.

Copy link

commented Aug 28, 2017

@vicb vicb removed the PR action: merge label Aug 28, 2017

@IgorMinar
Copy link
Member

left a comment

lgtm for the locals move

@vicb vicb force-pushed the vicb:0828-i18n branch from 79e8ee5 to 6aa89fb Aug 28, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Aug 28, 2017

@vicb vicb force-pushed the vicb:0828-i18n branch from 6aa89fb to c8de8e0 Aug 28, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Aug 28, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Aug 28, 2017

@vicb vicb force-pushed the vicb:0828-i18n branch from bae0cc4 to 6c222a3 Aug 28, 2017

@ocombe

ocombe approved these changes Aug 28, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Aug 28, 2017

@vicb vicb force-pushed the vicb:0828-i18n branch from 6c222a3 to 11d0de6 Aug 28, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Aug 28, 2017

ocombe and others added some commits Aug 21, 2017

feat(common): generate `closure-locale.ts` to tree shake locale data
Closure will only keep the data for the locale defined in `goog.LOCALE`

@vicb vicb force-pushed the vicb:0828-i18n branch from 11d0de6 to ae9aba4 Aug 28, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Aug 28, 2017

@vicb

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2017

Labelled "blocked" because it should be merged in master, not in g3 (a distinct CL is ready to be merged there)

@mhevery mhevery added cla: yes and removed cla: no labels Aug 29, 2017

@mhevery mhevery closed this in 4c45347 Aug 29, 2017

mhevery added a commit that referenced this pull request Aug 29, 2017

mhevery added a commit that referenced this pull request Aug 29, 2017

mhevery added a commit that referenced this pull request Aug 29, 2017

mhevery added a commit that referenced this pull request Aug 29, 2017

feat(common): generate `closure-locale.ts` to tree shake locale data (#…
…18907)

Closure will only keep the data for the locale defined in `goog.LOCALE`

PR Close #18907

@vicb vicb deleted the vicb:0828-i18n branch Sep 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.