Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): remove deprecated `OpaqueToken` #18971

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@ocombe
Copy link
Contributor

ocombe commented Aug 31, 2017

PR Type

What kind of change does this PR introduce?

[x] Other... Please describe: removing deprecated code

What is the current behavior?

OpaqueToken was deprecated since v4.

What is the new behavior?

OpaqueToken has been removed. Use InjectionToken instead.

Does this PR introduce a breaking change?

[x] Yes

Other informations

I had to update the dependencies for angular material in the integration test, because the old version was still using OpaqueToken

@ocombe ocombe requested a review from vicb Aug 31, 2017

@googlebot googlebot added the cla: yes label Aug 31, 2017

@ocombe ocombe force-pushed the ocombe:remove-opaque-token branch from 40af713 to 6c8a794 Aug 31, 2017

@angular angular deleted a comment from mary-poppins Aug 31, 2017

@ocombe ocombe force-pushed the ocombe:remove-opaque-token branch from 6c8a794 to 641b119 Aug 31, 2017

@vicb

vicb approved these changes Aug 31, 2017

@angular angular deleted a comment from mary-poppins Aug 31, 2017

@vicb

This comment has been minimized.

Copy link
Contributor

vicb commented Aug 31, 2017

tap/167149230 -> blocked on flex layout being updated

@ocombe ocombe force-pushed the ocombe:remove-opaque-token branch from 641b119 to 98cd676 Sep 1, 2017

refactor(core): remove deprecated `OpaqueToken`
BREAKING CHANGE: `OpaqueToken` has been removed as it was deprecated since v4. Use `InjectionToken` instead.

@ocombe ocombe force-pushed the ocombe:remove-opaque-token branch from 98cd676 to 119e4e0 Sep 1, 2017

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Sep 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.