New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): deprecate i18n comments in favor of `ng-container` #18998

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@ocombe
Contributor

ocombe commented Sep 1, 2017

PR Type

What kind of change does this PR introduce?

[x] Feature

What is the current behavior?

I18n comments require a lot of code to work, it's a big effort to maintain and it can easily be replaced by <ng-container i18n></ng-container>

What is the new behavior?

I18n comments have been deprecated and will print a warning in dev mode

Does this PR introduce a breaking change?

[x] No
@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Sep 1, 2017

@vicb
  • see inline comments
  • add DEPRACTIONS in the commit body with BEFORE/ACTION code snippet.
    Thanks

@ocombe ocombe requested a review from juleskremer Sep 1, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Sep 1, 2017

@juleskremer

lgtm

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Sep 1, 2017

@vicb

see inline comments

@vicb

vicb approved these changes Sep 5, 2017

@vicb

This comment has been minimized.

Show comment
Hide comment
@vicb

vicb Sep 5, 2017

Contributor

@ocombe please check what is wrong with Travis

Contributor

vicb commented Sep 5, 2017

@ocombe please check what is wrong with Travis

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Sep 5, 2017

@angular angular deleted a comment from mary-poppins Sep 5, 2017

@angular angular deleted a comment from mary-poppins Sep 5, 2017

@mhevery mhevery closed this in 66a5dab Sep 6, 2017

gkalpak added a commit to gkalpak/angular that referenced this pull request Sep 6, 2017

test(aio): fix docs example e2e test
Remove an assertion that is no longer true. This was supposed to be removed in #18998,
but was somehow dropped from 66a5dab (probably due to a bad rebase).

(Travis has been failing due to this since
https://travis-ci.org/angular/angular/jobs/272321759.)

gkalpak added a commit to gkalpak/angular that referenced this pull request Sep 6, 2017

test(aio): fix docs example e2e test
Remove an assertion that is no longer true. This was supposed to be removed in #18998,
but was somehow dropped from 66a5dab (probably due to a bad rebase).

(Travis has been failing due to this since
https://travis-ci.org/angular/angular/jobs/272321759.)

mhevery added a commit that referenced this pull request Sep 6, 2017

test(aio): fix docs example e2e test (#19070)
Remove an assertion that is no longer true. This was supposed to be removed in #18998,
but was somehow dropped from 66a5dab (probably due to a bad rebase).

(Travis has been failing due to this since
https://travis-ci.org/angular/angular/jobs/272321759.)

@ocombe ocombe deleted the ocombe:deprecate-i18n-comments branch Sep 11, 2017

@ocombe ocombe restored the ocombe:deprecate-i18n-comments branch Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment