Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf compiler typecheck #19152

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@tbosch
Copy link
Member

tbosch commented Sep 11, 2017

No description provided.

@googlebot googlebot added the cla: yes label Sep 11, 2017

@tbosch tbosch requested a review from vicb Sep 11, 2017

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Sep 11, 2017

@tbosch tbosch force-pushed the tbosch:perf_typecheck branch from 6e7275b to 4c37f77 Sep 12, 2017

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Sep 12, 2017

@tbosch tbosch force-pushed the tbosch:perf_typecheck branch from 4c37f77 to 052b1e7 Sep 12, 2017

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Sep 12, 2017

@@ -21,6 +21,14 @@ export interface Diagnostic {
source: 'angular';
}

export function isTsDiagnostic(diagnostic: any): diagnostic is ts.Diagnostic {
return diagnostic && diagnostic.source != 'angular';

This comment has been minimized.

Copy link
@vicb

vicb Sep 12, 2017

Contributor

should return a boolean (same below)

This comment has been minimized.

Copy link
@vicb

vicb Sep 12, 2017

Contributor

also use !== for consistency while you're at it

This comment has been minimized.

Copy link
@tbosch

tbosch Sep 12, 2017

Author Member

Done

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Sep 12, 2017

private actions: Expression[] = [];

constructor(
private _options: AotCompilerOptions, private reflector: StaticReflector,

This comment has been minimized.

Copy link
@vicb

vicb Sep 12, 2017

Contributor

nit: why _ only for one field ? remove ?

This comment has been minimized.

Copy link
@tbosch

tbosch Sep 12, 2017

Author Member

Removed all _ in this file...

@vicb

vicb approved these changes Sep 12, 2017

Copy link
Contributor

vicb left a comment

Please address the minor comments

@tbosch tbosch force-pushed the tbosch:perf_typecheck branch from 84c69ce to 3c8290b Sep 12, 2017

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Sep 12, 2017

@tbosch tbosch force-pushed the tbosch:perf_typecheck branch 2 times, most recently from 136ee51 to e6387aa Sep 12, 2017

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Sep 12, 2017

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Sep 12, 2017

@tbosch tbosch force-pushed the tbosch:perf_typecheck branch from e6387aa to f2e64c0 Sep 12, 2017

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Sep 12, 2017

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Sep 13, 2017

feat(compiler): reuse the TypeScript typecheck for template typecheck…
…ing.

This speeds up the compilation process significantly.

Also introduces a new option `fullTemplateTypeCheck` to do more checks in templates:
- check expressions inside of templatized content (e.g. inside of `<div *ngIf>`).
- check the arguments of calls to the `transform` function of pipes
- check references to directives that were exposed as variables via `exportAs`

@tbosch tbosch force-pushed the tbosch:perf_typecheck branch from da29984 to 6cfdd35 Sep 14, 2017

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Sep 14, 2017

@matsko matsko closed this in 996c7c2 Sep 14, 2017

@tbosch tbosch deleted the tbosch:perf_typecheck branch Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.