New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(animations): support negative query option values #19259

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@matsko
Member

matsko commented Sep 18, 2017

No description provided.

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Sep 18, 2017

results.push(...this._driver.query(this.element, selector, multi));
let elements = this._driver.query(this.element, selector, multi);
if (limit !== 0) {
elements = limit < 0 ? elements.slice(elements.length + limit, elements.length) :

This comment has been minimized.

@mhevery

mhevery Sep 20, 2017

Member

Could you explain how the test you have tests this? The limit in test is 2, which is not negative.

@mhevery

mhevery Sep 20, 2017

Member

Could you explain how the test you have tests this? The limit in test is 2, which is not negative.

This comment has been minimized.

@mhevery

mhevery Sep 20, 2017

Member

Ohh, I am confused, Isee the other test. All good.

@mhevery

mhevery Sep 20, 2017

Member

Ohh, I am confused, Isee the other test. All good.

results.push(...this._driver.query(this.element, selector, multi));
let elements = this._driver.query(this.element, selector, multi);
if (limit !== 0) {
elements = limit < 0 ? elements.slice(elements.length + limit, elements.length) :

This comment has been minimized.

@mhevery

mhevery Sep 20, 2017

Member

Ohh, I am confused, Isee the other test. All good.

@mhevery

mhevery Sep 20, 2017

Member

Ohh, I am confused, Isee the other test. All good.

@vicb vicb closed this in 86ffacf Sep 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment