Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(animations): reduce size of bundle by removing AST classes #19539

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@matsko
Copy link
Member

commented Oct 3, 2017

This CL refactors the animation AST code to make use of interfaces instead of classes. Given that interfaces are not persisted during runtime the removal of classes should nicely cut down on size for the animations-browser bundle.

-- before --
animations-browser.umd.js = 222kb
animations-browser.umd.min.js = 107kb

-- after --
animations-browser.umd.js = 213kb
animations-browser.umd.min.js = 102kb

@googlebot googlebot added the cla: yes label Oct 3, 2017

@matsko matsko force-pushed the matsko:animation_classes_perf branch from d963f52 to e8027e9 Oct 3, 2017

@matsko matsko requested a review from mhevery Oct 3, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Oct 3, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Oct 3, 2017

@@ -87,6 +87,7 @@ export declare const enum AnimationMetadataType {
AnimateRef = 10,
Query = 11,
Stagger = 12,
Timings = 13,

This comment has been minimized.

Copy link
@IgorMinar

IgorMinar Oct 4, 2017

Member

is this intentional? I thought this was just internal refactoring.

This comment has been minimized.

Copy link
@matsko

matsko Oct 4, 2017

Author Member

Yes this was intentional, but now that I think about it more I think I can work around this.

@matsko matsko force-pushed the matsko:animation_classes_perf branch from e8027e9 to f8ac5b6 Oct 4, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Oct 4, 2017

perf(animations): reduce size of bundle by removing AST classes
This CL refactors the animation AST code to make use of interfaces instead of classes. Given that interfaces are not persisted during runtime the removal of classes should nicely cut down on size for the animations-browser bundle.

-- before --
animations-browser.umd.js = 222kb
animations-browser.umd.min.js = 107kb

-- after --
animations-browser.umd.js = 213kb
animations-browser.umd.min.js = 102kb

@matsko matsko force-pushed the matsko:animation_classes_perf branch from f8ac5b6 to cbab241 Oct 4, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Oct 4, 2017

@mhevery

mhevery approved these changes Oct 4, 2017

@tbosch tbosch modified the milestone: Merge-queue Oct 6, 2017

@chuckjaz chuckjaz closed this in d5c9c5f Oct 6, 2017

chuckjaz added a commit to chuckjaz/angular that referenced this pull request Oct 7, 2017

@chuckjaz chuckjaz reopened this Oct 9, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Oct 9, 2017

@chuckjaz chuckjaz closed this in c3a5269 Oct 9, 2017

@chuckjaz

This comment has been minimized.

Copy link
Member

commented Oct 11, 2017

@matsko This PR does not apply cleanly on 4.4.x. Can you produce a 4.4.x PR with this changes?

@matsko matsko deleted the matsko:animation_classes_perf branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.