New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): generate correct imports for type check blocks #19582

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@chuckjaz
Member

chuckjaz commented Oct 5, 2017

Fixes: #19485

PR Type

What kind of change does this PR introduce?

[x] Bugfix

What is the current behavior?

Issue Number: #19485

The compiler would not generate all the necessary variables to ensure correct imports for type-check blocks.

What is the new behavior?

All the require variables are generated ensuring the correct imports are generated.

Does this PR introduce a breaking change?

[ ] Yes
[x] No
@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Oct 5, 2017

@tbosch

tbosch approved these changes Oct 5, 2017

@tbosch

This comment has been minimized.

Show comment
Hide comment
@tbosch

tbosch Oct 6, 2017

Member

The e2e tests fail because some translations got reordered, probably because we generated files in a different order.

Member

tbosch commented Oct 6, 2017

The e2e tests fail because some translations got reordered, probably because we generated files in a different order.

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Oct 6, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Oct 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment