Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): generate correct imports for type check blocks #19582

Closed
wants to merge 1 commit into from

Conversation

@chuckjaz
Copy link
Contributor

commented Oct 5, 2017

Fixes: #19485

PR Type

What kind of change does this PR introduce?

[x] Bugfix

What is the current behavior?

Issue Number: #19485

The compiler would not generate all the necessary variables to ensure correct imports for type-check blocks.

What is the new behavior?

All the require variables are generated ensuring the correct imports are generated.

Does this PR introduce a breaking change?

[ ] Yes
[x] No
@mary-poppins

This comment has been minimized.

Copy link

commented Oct 5, 2017

@tbosch
tbosch approved these changes Oct 5, 2017
@tbosch

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2017

The e2e tests fail because some translations got reordered, probably because we generated files in a different order.

@chuckjaz chuckjaz force-pushed the chuckjaz:issue19485 branch from d74e4c4 to f152a8b Oct 6, 2017
@mary-poppins

This comment has been minimized.

Copy link

commented Oct 6, 2017

@chuckjaz chuckjaz force-pushed the chuckjaz:issue19485 branch from f152a8b to 067d59f Oct 16, 2017
@mary-poppins

This comment has been minimized.

Copy link

commented Oct 16, 2017

@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Sep 12, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.