New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(animations): always fire inner trigger callbacks even if blocked by parent animations #19753

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@matsko
Member

matsko commented Oct 16, 2017

Closes #19100

@googlebot googlebot added the cla: yes label Oct 16, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Oct 16, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Oct 17, 2017

@tbosch tbosch added this to the Merge-queue milestone Oct 17, 2017

@tbosch tbosch closed this in 5a9ed2d Oct 18, 2017

tbosch added a commit to tbosch/angular that referenced this pull request Oct 18, 2017

tbosch added a commit that referenced this pull request Oct 18, 2017

Revert "fix(animations): always fire inner trigger callbacks even if …
…blocked by parent animations (#19753)"

This reverts commit 5a9ed2d.
As it broke an internal test.

@tbosch tbosch reopened this Oct 18, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Oct 18, 2017

@tbosch

This comment has been minimized.

Show comment
Hide comment
@tbosch

tbosch Oct 18, 2017

Member

This broke a test in G3.

Member

tbosch commented Oct 18, 2017

This broke a test in G3.

@fxck

This comment has been minimized.

Show comment
Hide comment
@fxck

fxck Oct 29, 2017

@tbosch any chance this will get in before angular 5 final? It's a requirement for #19455 without which nested animations are pretty much broken..

fxck commented Oct 29, 2017

@tbosch any chance this will get in before angular 5 final? It's a requirement for #19455 without which nested animations are pretty much broken..

@matsko matsko removed this from the Merge-queue milestone Nov 1, 2017

@matsko matsko closed this Nov 10, 2017

@matsko matsko reopened this Nov 10, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Nov 10, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Nov 13, 2017

@jasonaden jasonaden closed this in d47b2a6 Nov 15, 2017

jasonaden added a commit that referenced this pull request Nov 15, 2017

mhevery added a commit that referenced this pull request Nov 16, 2017

Revert "fix(animations): always fire inner trigger callbacks even if …
…blocked by parent animations (#19753)"

This reverts commit d47b2a6.

mhevery added a commit that referenced this pull request Nov 16, 2017

Revert "fix(animations): always fire inner trigger callbacks even if …
…blocked by parent animations (#19753)"

This reverts commit bc4b4b5.
@matpag

This comment has been minimized.

Show comment
Hide comment
@matpag

matpag Nov 17, 2017

@mhevery This PR seems to have been reverted but it is listed in the current changelog for the 5.1.0-beta1 release. Am I missing something?

matpag commented Nov 17, 2017

@mhevery This PR seems to have been reverted but it is listed in the current changelog for the 5.1.0-beta1 release. Am I missing something?

mhevery added a commit that referenced this pull request Nov 18, 2017

mhevery added a commit that referenced this pull request Nov 22, 2017

wKoza added a commit to wKoza/angular that referenced this pull request Dec 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment