New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): do not add references to files outside of `rootDir` #19770

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@chuckjaz
Member

chuckjaz commented Oct 17, 2017

References to resources (such as .css files) that are generated into
the outDir directory outside of rootDir would cause a spurious
compiler error about not being able to find a files that ends in
'.ngstyle.ts'.

Also fixed a minor issue in compiler error reporting

Fixes: #19765, #19767

PR Type

What kind of change does this PR introduce?

[x] Bugfix

What is the current behavior?

Issue Number: #19765

If .css files are generated into a destination directory outside of the rootDir the compiler generate a spurious error message.

What is the new behavior?

The error message is no longer generated.

Does this PR introduce a breaking change?

[ ] Yes
[x] No
@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Oct 17, 2017

@tbosch

tbosch approved these changes Oct 17, 2017

fix(compiler-cli): do not add references to files outside of `rootDir`
References to resources (such as .css files) that are generated into
the `outDir` directory outside of `rootDir` would cause a spurious
compiler error about not being able to find a files that ends in
'.ngstyle.ts'.

Also fixed a minor issue in compiler error reporting

Fixes: #19765, #19767
@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Oct 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment