Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): don’t type check templates with `skipTemplateCodegen` #19909

Closed
wants to merge 1 commit into from

Conversation

@tbosch
Copy link
Contributor

commented Oct 24, 2017

This change is needed to prevent users’ builds from breaking.

If a user sets fullTemlateTypeCheck to true, we will
continue to check the templates even when skipTemplateCodegen is true
as well.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

This change is needed to prevent users’ builds from breaking.

If a user sets `fullTemlateTypeCheck` to true, we will
continue to check the templates even when `skipTemplateCodegen` is true
as well.

Related to #19906
@tbosch tbosch force-pushed the tbosch:skip_codegen branch from 67c9362 to 0461cf9 Oct 24, 2017
@tbosch tbosch requested a review from chuckjaz Oct 24, 2017
@tbosch

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2017

Note: the failure in lint is because of the incorrect commit message for the release, i.e. unrelated to this commit.

@mary-poppins

This comment has been minimized.

Copy link

commented Oct 24, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Oct 24, 2017

@matsko matsko closed this in c92efc1 Oct 24, 2017
matsko added a commit that referenced this pull request Oct 24, 2017
…19909)

This change is needed to prevent users’ builds from breaking.

If a user sets `fullTemlateTypeCheck` to true, we will
continue to check the templates even when `skipTemplateCodegen` is true
as well.

Related to #19906

PR Close #19909
@tbosch tbosch deleted the tbosch:skip_codegen branch Nov 1, 2017
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Sep 12, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.