Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): automatically set `emitDecoratorMetadata` when `"annot… #19927

Closed
wants to merge 1 commit into from

Conversation

@tbosch
Copy link
Contributor

commented Oct 25, 2017

…ationsAs": "static fields”`

This is a workaround for angular/tsickle#635.

Fixes #19916

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@mary-poppins

This comment has been minimized.

Copy link

commented Oct 25, 2017

writeConfig(`{
"extends": "./tsconfig-base.json",
"angularCompilerOptions": {
"annotationsAs": "static fields"

This comment has been minimized.

Copy link
@chuckjaz

chuckjaz Oct 25, 2017

Contributor

Explicitly set emitDecoratorMetadata to false to make it more clear what this test is testing.

…ationsAs": "static fields”`

This is a workaround for angular/tsickle#635.

Fixes #19916
@tbosch tbosch force-pushed the tbosch:emit_decorators branch from 2308075 to 31d4fbe Oct 25, 2017
@mary-poppins

This comment has been minimized.

Copy link

commented Oct 25, 2017

@matsko matsko closed this in d567246 Oct 25, 2017
matsko added a commit that referenced this pull request Oct 25, 2017
…ationsAs": "static fields”` (#19927)

This is a workaround for angular/tsickle#635.

Fixes #19916
PR Close #19927
@tbosch tbosch removed this from For 5.0 Final in Compiler Oct 25, 2017
@tbosch tbosch deleted the tbosch:emit_decorators branch Nov 1, 2017
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Sep 12, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.