New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): avoid producing source mappings for host views #19965

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@chuckjaz
Member

chuckjaz commented Oct 27, 2017

The host view doesn't map back to user code so the template compiler
produces a blank url for them.

PR Type

What kind of change does this PR introduce?

[x] Bugfix

What is the current behavior?

The source maps would contain a file mapping "../../" or similar.

What is the new behavior?

The source maps no longer contain an invalid file name.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@googlebot googlebot added the cla: yes label Oct 27, 2017

fix(compiler-cli): avoid producing source mappings for host views
The host view doesn't map back to user code so the template compiler
produces a blank `url` for them.
@tbosch

tbosch approved these changes Oct 27, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Oct 27, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Oct 27, 2017

@tbosch tbosch referenced this pull request Oct 27, 2017

Closed

Template source maps cause issues for source-map-explorer #19840

0 of 2 tasks complete

@chuckjaz chuckjaz added this to the v5.0.0 milestone Oct 27, 2017

matsko added a commit that referenced this pull request Oct 28, 2017

fix(compiler-cli): avoid producing source mappings for host views (#1…
…9965)

The host view doesn't map back to user code so the template compiler
produces a blank `url` for them.

PR Close #19965

@matsko matsko closed this in 22c66f0 Oct 28, 2017

@chuckjaz chuckjaz removed this from For 5.0 Final in Compiler Nov 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment