Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: @angular/elements PR #19469 #20152

Merged
merged 1 commit into from Nov 3, 2017

Conversation

IgorMinar
Copy link
Contributor

This PR was merged without API docs and general rollout plan.

We can't release this as is in 5.1 without a plan for documentation, cli integration, etc.

@IgorMinar
Copy link
Contributor Author

@gkalpak @mhevery sorry but we have to revert the elements PR. Without a plan how to bring this to production, this PR will only cause issues as we get close to the 5.1 release and the necessary prerequisites are note ready.

Please propose a full rollout plan that includes docs, cli integration, google3 integration - see the design doc template for all the requirements. We should also have a clear owner of this effort who could work with @manughub on rolling this out. This feature was originally planned for rollout in Q1 of next year, so unless we changed our mind about this, we should have a discussion about it.

@mary-poppins
Copy link

You can preview e00ef9a at https://pr20152-e00ef9a.ngbuilds.io/.

@IgorMinar IgorMinar added area: elements Issues related to Angular Elements action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Nov 3, 2017
@trotyl
Copy link
Contributor

trotyl commented Nov 3, 2017

Could we just have one commit for the elements-builds repo first, so we can use that for demos or other explore works instead of all building our own 🙏

Sorry, found that already exists 😄

@mary-poppins
Copy link

You can preview e22d4cd at https://pr20152-e22d4cd.ngbuilds.io/.

@IgorMinar
Copy link
Contributor Author

IgorMinar commented Nov 3, 2017 via email

@IgorMinar IgorMinar added this to the 5.0.x milestone Nov 3, 2017
@gkalpak
Copy link
Member

gkalpak commented Nov 3, 2017

@IgorMinar, is it intentional that this PR does not reverts the whole original PR? All packages/elements/* files are still left behind.

@gkalpak
Copy link
Member

gkalpak commented Nov 3, 2017

And appear in the docs 😁: https://pr20152-e22d4cd.ngbuilds.io/api?query=elements

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR was not properly reverted.

@IgorMinar
Copy link
Contributor Author

IgorMinar commented Nov 3, 2017 via email

This PR was merged without API docs and general rollout plan.

We can't release this as is in 5.1 without a plan for documentation, cli integration, etc.
@IgorMinar
Copy link
Contributor Author

@gkalpak done

@IgorMinar
Copy link
Contributor Author

lint check is failing because the revert removed support for "element" commit message scope. I think we should just ignore this as it won't affect anything after the revert is merged.

@mary-poppins
Copy link

You can preview b8af122 at https://pr20152-b8af122.ngbuilds.io/.

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@IgorMinar
Copy link
Contributor Author

IgorMinar commented Nov 3, 2017

sending this for merge. for explanation of the lint failure see: #20152 (comment)

the travis-ci/push failure is irrelevant - I accidentally pushed an older version of this branch to the upstream repo - this branch has since been deleted, but the ci failure didn't disappear from this pr.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 3, 2017
@vicb vicb merged commit 3997d97 into angular:master Nov 3, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: elements Issues related to Angular Elements cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants