New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: @angular/elements PR #19469 #20152
Conversation
e00ef9a
to
e22d4cd
Compare
@gkalpak @mhevery sorry but we have to revert the elements PR. Without a plan how to bring this to production, this PR will only cause issues as we get close to the 5.1 release and the necessary prerequisites are note ready. Please propose a full rollout plan that includes docs, cli integration, google3 integration - see the design doc template for all the requirements. We should also have a clear owner of this effort who could work with @manughub on rolling this out. This feature was originally planned for rollout in Q1 of next year, so unless we changed our mind about this, we should have a discussion about it. |
You can preview e00ef9a at https://pr20152-e00ef9a.ngbuilds.io/. |
Sorry, found that already exists 😄 |
You can preview e22d4cd at https://pr20152-e22d4cd.ngbuilds.io/. |
there is at least one build in the elements-builds repo already:
https://github.com/angular/elements-builds
…On Fri, Nov 3, 2017 at 3:22 PM Mary Poppins ***@***.***> wrote:
You can preview e22d4cd
<e22d4cd>
at https://pr20152-e22d4cd.ngbuilds.io/.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20152 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANM6PHxYxG4DiePES8i0dxL_aGFc3b-ks5syyG5gaJpZM4QRIgI>
.
|
@IgorMinar, is it intentional that this PR does not reverts the whole original PR? All |
And appear in the docs 😁: https://pr20152-e22d4cd.ngbuilds.io/api?query=elements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR was not properly reverted.
Hmm. You are right. I'll redo the pr
…On Fri, Nov 3, 2017, 7:13 PM George Kalpakas ***@***.***> wrote:
***@***.**** requested changes on this pull request.
The PR was not properly reverted.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20152 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANM6LwPt4jwJfgV0v-WUL_c_B2dRhDgks5sy1fEgaJpZM4QRIgI>
.
|
This PR was merged without API docs and general rollout plan. We can't release this as is in 5.1 without a plan for documentation, cli integration, etc.
e22d4cd
to
b8af122
Compare
@gkalpak done |
lint check is failing because the revert removed support for "element" commit message scope. I think we should just ignore this as it won't affect anything after the revert is merged. |
You can preview b8af122 at https://pr20152-b8af122.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢
sending this for merge. for explanation of the lint failure see: #20152 (comment) the |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR was merged without API docs and general rollout plan.
We can't release this as is in 5.1 without a plan for documentation, cli integration, etc.