Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(forms): allow markAsPending to emit events #20212
Please check if your PR fulfills the following requirements:
What is the current behavior?
markAsPending cannot emit events
What is the new behavior?
markAsPending now emits events
Does this PR introduce a breaking change?
if we are making an intentional breaking change and we believe it's ok, because the impact is negligible then we should ensure that the commit message has the following information:
- what as the old behavior
- what is the new behavior
- how do we suggest developers migrate their code if they were affected by this change
Additionally we should also mention in the commit message why we believe that this change is not going to cause lots of developer pain.
otherwise lgtm - I'll let Kara ensure that these things get fixed and send the PR for merge.
referenced this pull request
Feb 7, 2018
@kara Updated the Commit Message and added some detail to the jsdoc, let me know if you need any other changes.