New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forms): allow nulls on setAsyncValidators #20327

Closed
wants to merge 1 commit into
base: master
from

Conversation

@Toxicable
Contributor

Toxicable commented Nov 10, 2017

closes #20296

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Feature

What is the current behavior?

does not allow nulls for setAsyncValidators

Issue Number: 20296

What is the new behavior?

setAsyncValidators allows nulls

Does this PR introduce a breaking change?

[ ] Yes
[x] No
@kara

kara approved these changes Nov 30, 2017

LGTM

@kara

This comment has been minimized.

Show comment
Hide comment
@kara

kara Nov 30, 2017

Contributor

@IgorMinar @mhevery Can one of you do a quick public API review?

Contributor

kara commented Nov 30, 2017

@IgorMinar @mhevery Can one of you do a quick public API review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment