New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler-cli): improve error messages produced during structural errors #20459

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@chuckjaz
Member

chuckjaz commented Nov 15, 2017

The errors produced when error were encountered while interpreting the
content of a directive was often incomprehencible. With this change
these kind of error messages should be easier to understand and diagnose.

PR Type

What kind of change does this PR introduce?

[x] Feature

What is the current behavior?

The errors reported by static reflector are often incomprehensible.

What is the new behavior?

The errors are now somewhat more comprehensible.

Part of #19700

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@googlebot googlebot added the cla: yes label Nov 15, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Nov 15, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Nov 16, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Nov 20, 2017

@chuckjaz

This comment has been minimized.

Show comment
Hide comment
@chuckjaz

chuckjaz Nov 20, 2017

Member

CARETAKER: This PR increases the size of the compiler to improve the static reflector errors so the size failure is expected.

Member

chuckjaz commented Nov 20, 2017

CARETAKER: This PR increases the size of the compiler to improve the static reflector errors so the size failure is expected.

const FORMATTED_MESSAGE = 'ngFormattedMessage';
function indentStr(level: number): string {

This comment has been minimized.

@vicb

vicb Nov 20, 2017

Contributor

nit: nice code but can't we use ''.repeat() ?

@vicb

vicb Nov 20, 2017

Contributor

nit: nice code but can't we use ''.repeat() ?

This comment has been minimized.

@chuckjaz

chuckjaz Nov 20, 2017

Member

We cannot use repeat yet so I am keeping this for now.

@chuckjaz

chuckjaz Nov 20, 2017

Member

We cannot use repeat yet so I am keeping this for now.

@vicb

Nice PR !
A few minor findings and some nits.

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Nov 20, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Nov 20, 2017

@vicb

vicb approved these changes Nov 27, 2017

feat(compiler-cli): improve error messages produced during structural…
… errors

The errors produced when error were encountered while interpreting the
content of a directive was often incomprehencible. With this change
these kind of error messages should be easier to understand and diagnose.
@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Nov 27, 2017

@mhevery mhevery closed this in 8ecda94 Nov 28, 2017

chuckjaz added a commit to chuckjaz/angular that referenced this pull request Nov 28, 2017

wKoza added a commit to wKoza/angular that referenced this pull request Dec 2, 2017

feat(compiler-cli): improve error messages produced during structural…
… errors (angular#20459)

The errors produced when error were encountered while interpreting the
content of a directive was often incomprehencible. With this change
these kind of error messages should be easier to understand and diagnose.

PR Close angular#20459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment