New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform-browser-dynamic): export `JitCompilerFactory` #20478

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@ocombe
Contributor

ocombe commented Nov 16, 2017

PR Type

What kind of change does this PR introduce?

[X] Feature

What is the current behavior?

The JitCompilerFactory is not exported in Angular v5

Issue Number: #20125

What is the new behavior?

JitCompilerFactory is now exported by the platform-browser-dynamic package

Does this PR introduce a breaking change?

[x] No
@VSmirnov17

This comment has been minimized.

Show comment
Hide comment
@VSmirnov17

VSmirnov17 Nov 17, 2017

@ocombe Hello.

Update packages angular on version 5.1.0.beta1.

Try to import:
import {JitCompilerFactory} from "@angular/platform-browser-dynamic";

TypeScript error: has no exported member 'JitCompilerFactory'

Autoimport WebStorm set:
import {JitCompilerFactory} from "@angular/platform-browser-dynamic/src/compiler_factory";

When I try to build:

ERROR in ./src/app/bootstrap/providers.ts
Module not found: Error: Can't resolve '@angular/platform-browser-dynamic/src/compiler_factory' in '/home/vsmirnov/Desktop/angular5/proj/src/app/bootstrap'
 @ ./src/app/bootstrap/providers.ts 19:0-92
 @ ./src/app/modules/app.module.ts
 @ ./src/main.ts
 @ multi (webpack)-dev-server/client?http://localhost:4200 ./src/main.ts
Child html-webpack-plugin for "index.html":
     1 asset
       1 module
webpack: Failed to compile.

VSmirnov17 commented Nov 17, 2017

@ocombe Hello.

Update packages angular on version 5.1.0.beta1.

Try to import:
import {JitCompilerFactory} from "@angular/platform-browser-dynamic";

TypeScript error: has no exported member 'JitCompilerFactory'

Autoimport WebStorm set:
import {JitCompilerFactory} from "@angular/platform-browser-dynamic/src/compiler_factory";

When I try to build:

ERROR in ./src/app/bootstrap/providers.ts
Module not found: Error: Can't resolve '@angular/platform-browser-dynamic/src/compiler_factory' in '/home/vsmirnov/Desktop/angular5/proj/src/app/bootstrap'
 @ ./src/app/bootstrap/providers.ts 19:0-92
 @ ./src/app/modules/app.module.ts
 @ ./src/main.ts
 @ multi (webpack)-dev-server/client?http://localhost:4200 ./src/main.ts
Child html-webpack-plugin for "index.html":
     1 asset
       1 module
webpack: Failed to compile.
@ocombe

This comment has been minimized.

Show comment
Hide comment
@ocombe

ocombe Nov 17, 2017

Contributor

Well yes, this PR has not been merged yet

Contributor

ocombe commented Nov 17, 2017

Well yes, this PR has not been merged yet

@ocombe ocombe requested a review from mhevery Nov 17, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Nov 17, 2017

@angular angular deleted a comment from mary-poppins Nov 17, 2017

@angular angular deleted a comment from mary-poppins Nov 17, 2017

@angular angular deleted a comment from mary-poppins Nov 17, 2017

@angular angular deleted a comment from mary-poppins Nov 17, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Nov 17, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Nov 17, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Nov 17, 2017

@VSmirnov17

This comment has been minimized.

Show comment
Hide comment
@VSmirnov17

VSmirnov17 Nov 20, 2017

Good day!
When to wait for the merger?

VSmirnov17 commented Nov 20, 2017

Good day!
When to wait for the merger?

@angular angular deleted a comment from mary-poppins Nov 21, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Nov 21, 2017

wKoza added a commit to wKoza/angular that referenced this pull request Dec 2, 2017

@ocombe ocombe deleted the ocombe:feat/#20125-jit-compiler-factory branch Jan 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment