New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): ignore null metadatas #20557

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@victornoel
Contributor

victornoel commented Nov 21, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

See #20260.

Issue Number: #20260

What is the new behavior?

Ignore null metadatas.

It is a first proposition to start solving this annoying issue.
I suppose that if there are null metadatas, in general, it's better to ignore them than to fail in the language-service.
Concerning this particular bug (#20260), maybe I should also fix the fact that there are null metadata generated for locales? Tell me how to do that :)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Nov 21, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

googlebot commented Nov 21, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no label Nov 21, 2017

@victornoel

This comment has been minimized.

Show comment
Hide comment
@victornoel

victornoel Nov 21, 2017

Contributor

I signed it!

Contributor

victornoel commented Nov 21, 2017

I signed it!

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Nov 21, 2017

CLAs look good, thanks!

googlebot commented Nov 21, 2017

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Nov 21, 2017

@mhevery mhevery requested a review from chuckjaz Nov 21, 2017

fix(language-service): ignore null metadatas
There can be null metadatas in certain cases, for example with locales.

Fixes #20260
@mhevery

mhevery approved these changes Jan 2, 2018

@mhevery mhevery closed this in 3e47ea2 Jan 2, 2018

mhevery added a commit that referenced this pull request Jan 2, 2018

fix(language-service): ignore null metadatas (#20557)
There can be null metadatas in certain cases, for example with locales.

Fixes #20260

PR Close #20557

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

fix(language-service): ignore null metadatas (angular#20557)
There can be null metadatas in certain cases, for example with locales.

Fixes angular#20260

PR Close angular#20557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment