Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(animations): always fire inner trigger callbacks even if blocked by parent animations #20571

Closed
wants to merge 2 commits into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Nov 21, 2017

Closes #19100

@mary-poppins
Copy link

You can preview 328133b at https://pr20571-328133b.ngbuilds.io/.

@matsko matsko force-pushed the fix_parent_animation_detection branch from 328133b to 4255a75 Compare November 21, 2017 22:51
@mary-poppins
Copy link

You can preview 4255a75 at https://pr20571-4255a75.ngbuilds.io/.

@matsko
Copy link
Contributor Author

matsko commented Nov 21, 2017

This fails due to the UMD size getting bigger...

@matsko
Copy link
Contributor Author

matsko commented Nov 22, 2017

Landed as ffb6dbe

@matsko matsko closed this Nov 22, 2017
@matsko matsko deleted the fix_parent_animation_detection branch January 17, 2019 19:44
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested animation don't run and start callback is not fired
3 participants