New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): compiler not allows to import packages, whose name contains dot (e.g. "angular.com") #20634

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mmlleevvyy
Contributor

mmlleevvyy commented Nov 26, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Compiler not allows to import packages, whose name contains dot (e.g. "angular.com"). For example, below will fail with error "Trying to import a source file from a node_modules package":

import {ClassName} from "angular.com"

... will fail.

Issue Number: #20363

What is the new behavior?

Importing from package whose name contains dot (e.g. "angular.com") is now possible.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot googlebot added the cla: yes label Nov 26, 2017

@mmlleevvyy mmlleevvyy changed the title from Fix for #20363 issue - compiler not allows to import packages, whose name contains dot (e.g. "angular.com") to fix(compiler-cli): compiler not allows to import packages, whose name contains dot (e.g. "angular.com") Nov 26, 2017

@mhevery mhevery requested a review from chuckjaz Nov 28, 2017

@mmlleevvyy

This comment has been minimized.

Contributor

mmlleevvyy commented Dec 12, 2017

@chuckjaz Any chance to review this PR? Thanks.

@mmlleevvyy

This comment has been minimized.

Contributor

mmlleevvyy commented Jan 11, 2018

@mhevery @chuckjaz Any chance to review & merge this PR? It's so annoying, but very easy to fix. Please guys! #20363

@mhevery

This comment has been minimized.

Member

mhevery commented Jan 16, 2018

@chuckjaz can you have a look?
@mmlleevvyy Can you add test for this?

@mmlleevvyy

This comment has been minimized.

Contributor

mmlleevvyy commented Jan 17, 2018

@mhevery @chuckjaz Test added :-)

@mmlleevvyy

This comment has been minimized.

Contributor

mmlleevvyy commented Mar 29, 2018

@mhevery @chuckjaz Knock knock :-)

@mmlleevvyy

This comment has been minimized.

Contributor

mmlleevvyy commented Jun 13, 2018

@chuckjaz @mhevery Is there anything I can do to merge this PR?

@ngbot

This comment has been minimized.

ngbot bot commented Jun 13, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required status "code-review/pullapprove"
    pending status "ci/circleci: test_ivy_jit" is pending
    pending status "ci/circleci: lint" is pending
    pending status "ci/circleci: build-packages-dist" is pending
    pending status "ci/circleci: test" is pending
    pending status "ci/circleci: test_ivy_aot" is pending
    pending status "google3" is pending
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mhevery

This comment has been minimized.

mhevery added a commit that referenced this pull request Jun 14, 2018

@mhevery mhevery closed this in d8f7b29 Jun 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment