refactor(animations): instantiate Set-matching code with values in constructor #20725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstructor For some reason, prior to this fix, the boolean set matching code (within `animation_transition_expr.ts`) failed to remain the same when compiled with closure. This refactor makes sure that the code stays in tact. Reproduction Details: Passes without `ng build --prod`: https://burger.stackblitz.io/ Fails with `ng build --prod`: http://burger.fxck.cz/ Closes angular#20374
|
You can preview afea001 at https://pr20725-afea001.ngbuilds.io/. |
mhevery
approved these changes
Dec 2, 2017
jasonaden
pushed a commit
that referenced
this pull request
Dec 8, 2017
…nstructor (#20725) For some reason, prior to this fix, the boolean set matching code (within `animation_transition_expr.ts`) failed to remain the same when compiled with closure. This refactor makes sure that the code stays in tact. Reproduction Details: Passes without `ng build --prod`: https://burger.stackblitz.io/ Fails with `ng build --prod`: http://burger.fxck.cz/ Closes #20374 PR Close #20725
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, prior to this fix, the boolean set matching
code (within
animation_transition_expr.ts) failed to remainthe same when compiled with closure. This refactor makes sure
that the code stays in tact.
Reproduction Details:
Passes without
ng build --prod: https://burger.stackblitz.io/Fails with
ng build --prod: http://burger.fxck.cz/Closes #20374