New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service-worker): ensure initialised in browser only #20782

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@alxhub
Contributor

alxhub commented Dec 4, 2017

No description provided.

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Dec 4, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot commented Dec 4, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no label Dec 4, 2017

@alxhub alxhub added cla: yes and removed cla: no labels Dec 4, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Dec 4, 2017

@alxhub alxhub requested a review from IgorMinar Dec 4, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Dec 4, 2017

@IgorMinar

please explain the default value and resolve the merge conflict. otherwise lgtm. thanks!

Show outdated Hide outdated packages/service-worker/src/low_level.ts Outdated
@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Dec 4, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Dec 5, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Dec 5, 2017

@IgorMinar

The CI is not happy - compile-time error. Please fix. Otherwise lgtm

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Dec 5, 2017

@alxhub

This comment has been minimized.

Show comment
Hide comment
@alxhub

alxhub Dec 5, 2017

Contributor

@IgorMinar should be fixed now.

Contributor

alxhub commented Dec 5, 2017

@IgorMinar should be fixed now.

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Dec 5, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Dec 5, 2017

@IgorMinar IgorMinar closed this in 7cabaa0 Dec 6, 2017

@etsuo etsuo referenced this pull request Mar 16, 2018

Open

Add App Shell #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment