New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service-worker): esm2015 points to wrong path #20800

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@Doehl
Contributor

Doehl commented Dec 5, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The Service Worker package points to a non-existing path for the esm2015 build.
Current value is "esm15"

This makes build with Google Closure Compiler impossible with following settings.
--package_json_entry_names es2015
--process_common_js_modules

Issue Number: N/A

What is the new behavior?

The esm2015 value should be "esm2015".

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

fix(service-worker): esm2015 points to wrong path
The package.json esm2015 points to the wrong path.
"esm15" should be "esm2015"

Service Worker can't be compiled with use of Closure Compiler
@alxhub

alxhub approved these changes Dec 5, 2017

IgorMinar added a commit that referenced this pull request Dec 6, 2017

fix(service-worker): esm2015 points to wrong path (#20800)
The package.json esm2015 points to the wrong path.
"esm15" should be "esm2015"

Service Worker can't be compiled with use of Closure Compiler
PR Close #20800

@IgorMinar IgorMinar closed this in da3563c Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment