New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(animations): renaming issue with DOMAnimation. #21125

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mprobst
Contributor

mprobst commented Dec 21, 2017

Closure Compiler renames all properties that are "internal" to the
program. DOMAnimation however is external, it is a browser API, so its
fields must not be renamed.

This change marks DOMAnimation as external using declare interface,
which will cause Closure Compiler to back off and prevent renaming of
any of its fields.

PR Type

What kind of change does this PR introduce?

[x] Bugfix

What is the current behavior?

Closure Compiler in advanced mode with types will break apps using animations.

Issue Number: N/A

What is the new behavior?

Apps work :-)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

While we have g3 internal tests for this, we do not have a setup to be able to test this in the open source repository, I'm afraid.

fix(animations): renaming issue with DOMAnimation.
Closure Compiler renames all properties that are "internal" to the
program. `DOMAnimation` however is external, it is a browser API, so its
fields must not be renamed.

This change marks `DOMAnimation` as external using `declare interface`,
which will cause Closure Compiler to back off and prevent renaming of
any of its fields.

@googlebot googlebot added the cla: yes label Dec 21, 2017

@mprobst mprobst requested a review from matsko Dec 21, 2017

@IgorMinar

This comment has been minimized.

Show comment
Hide comment
@IgorMinar

IgorMinar Dec 21, 2017

Member

the ci failure is an unrelated flake that we are investigating.

Member

IgorMinar commented Dec 21, 2017

the ci failure is an unrelated flake that we are investigating.

IgorMinar added a commit that referenced this pull request Dec 21, 2017

fix(animations): renaming issue with DOMAnimation. (#21125)
Closure Compiler renames all properties that are "internal" to the
program. `DOMAnimation` however is external, it is a browser API, so its
fields must not be renamed.

This change marks `DOMAnimation` as external using `declare interface`,
which will cause Closure Compiler to back off and prevent renaming of
any of its fields.

PR Close #21125

@IgorMinar IgorMinar closed this in 871ece6 Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment