New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-work for ng_package rule #22176

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@alexeagle
Contributor

alexeagle commented Feb 12, 2018

version stamping and ts_library->ng_module

@alexeagle alexeagle requested a review from IgorMinar Feb 12, 2018

@googlebot

This comment has been minimized.

googlebot commented Feb 12, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no label Feb 12, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 12, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 12, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 12, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 12, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 12, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 12, 2018

You can preview fd1034f at https://pr22176-fd1034f.ngbuilds.io/.

@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 12, 2018

@IgorMinar

This comment has been minimized.

Member

IgorMinar commented Feb 13, 2018

hmm.. ci is not happy. I think you should cherry-picked/squash c724e7d into this PR otherwise people running bazel build will have a bad time.

you will also need to pull tags on CI as instructed in the error message in that commit (c724e7d).

@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 13, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 13, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 13, 2018

@IgorMinar IgorMinar changed the title from chore(bazel): pre-work for ng_package rule to feat(bazel): pre-work for ng_package rule Feb 13, 2018

@IgorMinar

This comment has been minimized.

Member

IgorMinar commented Feb 13, 2018

@alexeagle should we consider upstreaming the version stamping some place outside of angular/angular (or into @angular/bazel) - I expect that @jelbourn and @hansl will also want to use it.

this would be done in a separate PR so that we don't block this one any more.

@alexeagle alexeagle changed the title from feat(bazel): pre-work for ng_package rule to pre-work for ng_package rule Feb 13, 2018

alexeagle added some commits Feb 13, 2018

refactor(bazel): convert most ts_library to ng_module
This is necessary so we can produce ng metadata for our packages that are published as libraries
feat(bazel): introduce a binary stamping feature
This grabs version control metadata and makes it available in the build, eg. to put in the version field for released artifacts
@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 13, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 13, 2018

@alexeagle

This comment has been minimized.

Contributor

alexeagle commented Feb 14, 2018

found some issues using this from ng_package, will fix up in this PR, not ready to merge yet...

@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 14, 2018

feat(bazel): ng_module produces bundle index
It creates the bundle index .d.ts and .metadata.json files.
The names are based on the ng_module target.
@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 14, 2018

vicb added a commit that referenced this pull request Feb 15, 2018

refactor(bazel): convert most ts_library to ng_module (#22176)
This is necessary so we can produce ng metadata for our packages that are published as libraries

PR Close #22176

vicb added a commit that referenced this pull request Feb 15, 2018

feat(bazel): introduce a binary stamping feature (#22176)
This grabs version control metadata and makes it available in the build, eg. to put in the version field for released artifacts

PR Close #22176

vicb added a commit that referenced this pull request Feb 15, 2018

feat(bazel): ng_module produces bundle index (#22176)
It creates the bundle index .d.ts and .metadata.json files.
The names are based on the ng_module target.

PR Close #22176

@vicb vicb closed this in a069e08 Feb 15, 2018

vicb added a commit that referenced this pull request Feb 15, 2018

feat(bazel): introduce a binary stamping feature (#22176)
This grabs version control metadata and makes it available in the build, eg. to put in the version field for released artifacts

PR Close #22176

vicb added a commit that referenced this pull request Feb 15, 2018

feat(bazel): ng_module produces bundle index (#22176)
It creates the bundle index .d.ts and .metadata.json files.
The names are based on the ng_module target.

PR Close #22176

jbogarthyde added a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018

refactor(bazel): convert most ts_library to ng_module (angular#22176)
This is necessary so we can produce ng metadata for our packages that are published as libraries

PR Close angular#22176

jbogarthyde added a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018

feat(bazel): introduce a binary stamping feature (angular#22176)
This grabs version control metadata and makes it available in the build, eg. to put in the version field for released artifacts

PR Close angular#22176

jbogarthyde added a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018

feat(bazel): ng_module produces bundle index (angular#22176)
It creates the bundle index .d.ts and .metadata.json files.
The names are based on the ng_module target.

PR Close angular#22176

smdunn pushed a commit to smdunn/angular that referenced this pull request Feb 28, 2018

refactor(bazel): convert most ts_library to ng_module (angular#22176)
This is necessary so we can produce ng metadata for our packages that are published as libraries

PR Close angular#22176

smdunn pushed a commit to smdunn/angular that referenced this pull request Feb 28, 2018

feat(bazel): introduce a binary stamping feature (angular#22176)
This grabs version control metadata and makes it available in the build, eg. to put in the version field for released artifacts

PR Close angular#22176

smdunn pushed a commit to smdunn/angular that referenced this pull request Feb 28, 2018

feat(bazel): ng_module produces bundle index (angular#22176)
It creates the bundle index .d.ts and .metadata.json files.
The names are based on the ng_module target.

PR Close angular#22176

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

refactor(bazel): convert most ts_library to ng_module (angular#22176)
This is necessary so we can produce ng metadata for our packages that are published as libraries

PR Close angular#22176

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

feat(bazel): introduce a binary stamping feature (angular#22176)
This grabs version control metadata and makes it available in the build, eg. to put in the version field for released artifacts

PR Close angular#22176

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

feat(bazel): ng_module produces bundle index (angular#22176)
It creates the bundle index .d.ts and .metadata.json files.
The names are based on the ng_module target.

PR Close angular#22176

jmleoni pushed a commit to jmleoni/angular that referenced this pull request Oct 6, 2018

refactor(bazel): convert most ts_library to ng_module (angular#22176)
This is necessary so we can produce ng metadata for our packages that are published as libraries

PR Close angular#22176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment