New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform-browser): do not throw error when Hammer.js not loaded #22257

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@trotyl
Contributor

trotyl commented Feb 16, 2018

closes #16992

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #16992

What is the new behavior?

Just leave a warning and perform no functionality when Hammer.js not loaded.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot googlebot added the cla: yes label Feb 16, 2018

spyOn(mockConsole, 'warn');
expect(plugin.supports('swipe')).toBe(false);
expect(mockConsole.warn).toHaveBeenCalled();

This comment has been minimized.

@vicb

vicb Feb 17, 2018

Contributor

please check the message

@vicb

vicb approved these changes Feb 17, 2018

some cleanup.
please make this a feat (technically this is a breaking change and will go to master only)

@trotyl trotyl changed the title from fix(platform-browser): do not throw error when Hammer.js not loaded to feat(platform-browser): do not throw error when Hammer.js not loaded Feb 17, 2018

@vicb

This comment has been minimized.

Contributor

vicb commented Feb 17, 2018

Thanks for the updates !

cl/186105053

@ngbot

This comment has been minimized.

ngbot bot commented Feb 17, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required label: "PR target: *"
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@vicb vicb closed this in 991300b Feb 18, 2018

@trotyl trotyl deleted the trotyl:hammer-warning branch Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment