Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(common): properly check NaN value #22305
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
When the previous value is a wrapped one but the new value is not (while they're same), this still indicates no change happened, should not throw. (but not the opposite)
Does this PR introduce a breaking change?
changed the title
fix(core): not throw when old value is wrapped while new value is same unwrapped one
Mar 16, 2018
2 similar comments
referenced this pull request
Aug 16, 2018
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Once you've signed (or fixed any issues), please reply here (e.g.
What to do if you already signed the CLA
@trotyl Thanks, unfortunately its currently not possible to build angular on a windows machine so i had to fix the core.js directly and made sure (per postpublish npm script) that the change is not overwritten on install. dirty fix but at least its working until someone accepts this pr