Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): properly check NaN value #22305

Closed
wants to merge 1 commit into from

Conversation

@trotyl
Copy link
Contributor

commented Feb 19, 2018

closes #15721

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #15721, #18129

What is the new behavior?

When the previous value is a wrapped one but the new value is not (while they're same), this still indicates no change happened, should not throw. (but not the opposite)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Note: #15723 cannot fix the problem alone.
#15723 is correct, my thoughts were wrong.

@kevinmerckx

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2018

I'm very thankful for this fix. I hope it's gonna get merged soon!

@trotyl

This comment has been minimized.

Copy link
Contributor Author

commented Mar 16, 2018

Oops, just found out #15721 can only be fixed by combining this one and #15723 together...

EDIT: divided into two commits.

@trotyl trotyl force-pushed the trotyl:async-nan branch from da1a70b to 65247d2 Mar 16, 2018

@trotyl trotyl changed the title fix(core): not throw when old value is wrapped while new value is same unwrapped one fix AsyncPipe checkNoChange with WrappedValue Mar 16, 2018

@trotyl trotyl force-pushed the trotyl:async-nan branch from 65247d2 to add3e6a Mar 16, 2018

@ngbot

This comment has been minimized.

Copy link

commented Mar 20, 2018

Hi @trotyl! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

2 similar comments
@ngbot

This comment has been minimized.

Copy link

commented Mar 20, 2018

Hi @trotyl! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@ngbot

This comment has been minimized.

Copy link

commented Mar 20, 2018

Hi @trotyl! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@headsetsniper

This comment has been minimized.

Copy link

commented Aug 16, 2018

Please, @trotyl can you finish this? It would be a huge help

@trotyl

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2018

@headsetsniper It's just waiting for review, conflicts are left deliberately to understand when would the review happening.

@SebastianAtWork

This comment has been minimized.

Copy link

commented Oct 2, 2018

Please, can someone review this PR? We now have to work around this issue. The PR is so small and would help a lot of people.

@SebastianAtWork

This comment has been minimized.

Copy link

commented Oct 15, 2018

@trotyl Could i review it? i cant merge it but is there something i could do? Its a huge pain in our current project and i cant believe its open since February. Maybe it gets merged quicker if someone resolves the conflicts?

@SebastianAtWork

This comment has been minimized.

Copy link

commented Oct 15, 2018

@trotyl Or even better, if we resolve the conflicts, i can reference this branch in our project until it gets merged, right?

@trotyl trotyl force-pushed the trotyl:async-nan branch from add3e6a to 6a3df45 Oct 15, 2018

@googlebot

This comment has been minimized.

Copy link

commented Oct 15, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added cla: no and removed cla: yes labels Oct 15, 2018

@trotyl

This comment has been minimized.

Copy link
Contributor Author

commented Oct 15, 2018

@SebastianAtWork Rebased, feel free to fetch and use, but better to checkout another branch if you want to keep it up-to-date.

@googlebot

This comment has been minimized.

Copy link

commented Oct 15, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Oct 15, 2018

@SebastianAtWork

This comment has been minimized.

Copy link

commented Oct 16, 2018

@trotyl Thanks, unfortunately its currently not possible to build angular on a windows machine so i had to fix the core.js directly and made sure (per postpublish npm script) that the change is not overwritten on install. dirty fix but at least its working until someone accepts this pr

@Jarrich

This comment has been minimized.

Copy link

commented Jan 17, 2019

I could really use this PR. Bump.

@jasonaden jasonaden added this to the needsTriage milestone Jan 29, 2019

@trotyl trotyl force-pushed the trotyl:async-nan branch from 6a3df45 to 397a361 Apr 16, 2019

@trotyl trotyl requested a review from angular/fw-core as a code owner Apr 16, 2019

@trotyl trotyl changed the title fix AsyncPipe checkNoChange with WrappedValue fix(common): properly check NaN value Apr 16, 2019

@trotyl

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

Have had a second thought, the change made in #15723 is correct and mine was wrong.

#18129 is likely a different issue (or not an issue) which I cannot reproduce.

@mhevery mhevery self-assigned this Apr 17, 2019

@ngbot

This comment has been minimized.

Copy link

commented Apr 17, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: integration_test" is failing
    failure status "ci/circleci: test_aio" is failing
    failure status "ci/circleci: test_docs_examples_ivy" is failing
    pending missing required labels: PR target: *
    pending status "google3" is pending
    pending missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mhevery

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Have had a second thought, the change made in #15723 is correct and mine was wrong.

So should this be merged or closed?

@benlesh

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

@mhevery The other one was closed by @IgorMinar in favor of this one.

@trotyl We just need to get this one passing CI. :)

@trotyl trotyl force-pushed the trotyl:async-nan branch from 397a361 to 3b7d5c8 Apr 18, 2019

@trotyl

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

@mhevery Sorry for the confusion, I meant that my previous thoughts about WrappedValue is wrong, this should just be handled solely by change AsyncPipe.

@benlesh I'll fix the CI.

@trotyl

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

Hi @benlesh, I have rebased the change, the failure in DoCheck example seems to be a flake, which doesn't use async pipe and passed in my local environment.

@benlesh

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

@benlesh

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2019

@trotyl Can you put together a separate PR for the 7.2.x branch? I was unable to merge this into both there and master due to conflicts, so I'll target master with this one.

@benlesh benlesh closed this in 3f6bf6d Apr 20, 2019

@trotyl trotyl referenced this pull request Apr 22, 2019

Open

[7.2 only] fix(common): properly check NaN value #30023

4 of 14 tasks complete
@trotyl

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

@benlesh Created #30023

@trotyl trotyl deleted the trotyl:async-nan branch Apr 22, 2019

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.