New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform-server): bump Domino to v2.0 #22411

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@CaerusKaru
Copy link
Member

CaerusKaru commented Feb 23, 2018

BREAKING CHANGE:

  • Bump the dependency on Domino to 2.0 to resolve issues with
    namespacing

@googlebot googlebot added the cla: yes label Feb 23, 2018

@CaerusKaru CaerusKaru force-pushed the CaerusKaru:domino branch from 7e188d4 to 7dfd96b Feb 23, 2018

@vikerman vikerman self-requested a review Feb 26, 2018

@vikerman
Copy link
Contributor

vikerman left a comment

Please follow instruction at https://github.com/angular/angular/blob/master/yarn.lock.readme.md to update dependencies

feat(platform-server): bump Domino to v2.0
BREAKING CHANGE:

* Bump the dependency on Domino to 2.0 to resolve issues with
  namespacing

@CaerusKaru CaerusKaru force-pushed the CaerusKaru:domino branch from 7dfd96b to f54d671 Feb 26, 2018

@CaerusKaru

This comment has been minimized.

Copy link
Member Author

CaerusKaru commented Feb 26, 2018

@vikerman Fixed

@vikerman vikerman requested a review from mhevery Feb 26, 2018

@vikerman

This comment has been minimized.

Copy link
Contributor

vikerman commented Feb 26, 2018

Just to clarify - There is no API breakages from Domino - but they upped their major version.

@alexeagle alexeagle closed this in d3827a0 Feb 26, 2018

@CaerusKaru CaerusKaru deleted the CaerusKaru:domino branch Feb 26, 2018

smdunn pushed a commit to smdunn/angular that referenced this pull request Feb 28, 2018

feat(platform-server): bump Domino to v2.0 (angular#22411)
BREAKING CHANGE:

* Bump the dependency on Domino to 2.0 to resolve issues with
  namespacing

PR Close angular#22411

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

feat(platform-server): bump Domino to v2.0 (angular#22411)
BREAKING CHANGE:

* Bump the dependency on Domino to 2.0 to resolve issues with
  namespacing

PR Close angular#22411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment