New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): export functions to format numbers, percents, currencie… #22423

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@vicb
Contributor

vicb commented Feb 23, 2018

supersedes #22372 - fix the commit message

22372 was approved and green !

feat(common): export functions to format numbers, percents, currencie…
…s & dates

The utility functions `formatNumber`, `formatPercent`, `formatCurrency`, and `formatDate` used by the number, percent, currency and date pipes are now available for developers who want to use them outside of templates.

Fixes #20536
@googlebot

This comment has been minimized.

googlebot commented Feb 23, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 23, 2018

@ngbot

This comment has been minimized.

ngbot bot commented Feb 23, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "cla/google" is failing
    pending status "continuous-integration/travis-ci/pr" is pending
    pending status "code-review/pullapprove" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@vicb vicb closed this in 4180912 Feb 23, 2018

smdunn pushed a commit to smdunn/angular that referenced this pull request Feb 28, 2018

feat(common): export functions to format numbers, percents, currencie…
…s & dates (angular#22423)

The utility functions `formatNumber`, `formatPercent`, `formatCurrency`, and `formatDate` used by the number, percent, currency and date pipes are now available for developers who want to use them outside of templates.

Fixes angular#20536

PR Close angular#22423

@vicb vicb deleted the vicb:gh-22372 branch Mar 6, 2018

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

feat(common): export functions to format numbers, percents, currencie…
…s & dates (angular#22423)

The utility functions `formatNumber`, `formatPercent`, `formatCurrency`, and `formatDate` used by the number, percent, currency and date pipes are now available for developers who want to use them outside of templates.

Fixes angular#20536

PR Close angular#22423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment