New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng_package fixes #22499

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@alexeagle
Contributor

alexeagle commented Feb 28, 2018

No description provided.

feat(bazel): ng_package adds package.json props
We now add the 'main', 'module', 'es2015', and 'typings' properties,
pointing to where the packaging tool lays them out.

Fixes #22416
@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 28, 2018

@chuckjaz

One nit.

* @param content current file content
*/
function amendPackageJson(filePath: string, content: string) {
if (path.basename(filePath) === 'package.json') {

This comment has been minimized.

@chuckjaz

chuckjaz Feb 28, 2018

Member

Consider lifting this to the caller.

@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 28, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 28, 2018

alexeagle added a commit that referenced this pull request Feb 28, 2018

@alexeagle alexeagle closed this in b6c9410 Feb 28, 2018

This was referenced Mar 15, 2018

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

feat(bazel): ng_package adds package.json props (angular#22499)
We now add the 'main', 'module', 'es2015', and 'typings' properties,
pointing to where the packaging tool lays them out.

Fixes angular#22416

PR Close angular#22499

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment