Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(common): titlecase pipe #22600
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
What is the current behavior?
Current titlecase pipe doesn't work properly for non-latin alphabet and strings with qoutes
Issue Number: 16586
What is the new behavior?
Titlecase pipe works properly for all existing cases plus for non-latin alphabet and strings with qoutes
Does this PR introduce a breaking change?
I took already existing implementation from here and added some unit tests to verify broken functionality.
referenced this pull request
Mar 6, 2018
Yes, this is correct. After I researched it, I started to understand it a way better.
Before commiting transpiled form, I wanted to find out whether it will be possible to use
As you said, the only solution is to use long ES5 regular expression itself.
I updated the PR with corresponding change.
Since this is a very long string, I'm not really sure how to structure the code properly. I formatted and pushed as I think it should be. Please correct me if I'm wrong.
I updated this PR with the following changes:
You can preview 1d518db at https://pr22600-1d518db.ngbuilds.io/.
As discussed with @gkalpak, the PR was updated with the following changes: