Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(router): make routerLinkActive work with query params arrays #22666
The url_tree equalQueryParams and containsQueryParam methods did not handle query params that has arrays, which resulted in the routerLinkActive to not behave as expected, change was made to ensure query params with arrays are handled correctly
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #22223
What is the new behavior?
Arrays in query params are now handled properly when using routerLinkActive
Does this PR introduce a breaking change?
Done by @Zaid-Al-Omari
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Once you've signed (or fixed any issues), please reply here (e.g.
What to do if you already signed the CLA
So there's good news and bad news.
Note to project maintainer: This is a terminal state, meaning the
I Have signed the CLA and the bot accepted it.
Please review the changes and let me know if anything needs to be changed.
…in arrays (angular#22666) The url_tree equalQueryParams and containsQueryParam methods did not handle query params that has arrays, which resulted in the routerLinkActive to not behave as expected, change was made to ensure query params with arrays are handled correctly fixes angular#22223 PR Close angular#22666
This issue has been automatically locked due to inactivity.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.