New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler-cli): add support to extend `angularCompilerOptions` #22717

Closed
wants to merge 1 commit into
base: master
from

Conversation

@alan-agius4
Contributor

alan-agius4 commented Mar 12, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

TypeScript only supports merging and extending of compilerOptions.

Issue Number: #22684

What is the new behavior?

This is an implementation to support extending and inheriting of angularCompilerOptions from multiple files.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@alan-agius4

This comment has been minimized.

Show comment
Hide comment
@alan-agius4
Contributor

alan-agius4 commented Apr 15, 2018

@alan-agius4

This comment has been minimized.

Show comment
Hide comment
@alan-agius4

alan-agius4 Jul 29, 2018

Contributor

Bump @vicb and @alxhub

Contributor

alan-agius4 commented Jul 29, 2018

Bump @vicb and @alxhub

@alan-agius4

This comment has been minimized.

Show comment
Hide comment
@alan-agius4

alan-agius4 Aug 9, 2018

Contributor

Travis error looks to be a flake.

Contributor

alan-agius4 commented Aug 9, 2018

Travis error looks to be a flake.

@IgorMinar

Can we please add a documentation for this change? we shouldn't merge new features like this without docs. thanks!

the current compiler options are documented here: aio/content/guide/aot-compiler.md

@alan-agius4

This comment has been minimized.

Show comment
Hide comment
@alan-agius4

alan-agius4 Aug 14, 2018

Contributor

@IgorMinar, I have added the requested docs. Can you please review them?

Please feel free to suggest or do any changes.

Ps: I have also rebased and thanks for your review.

Contributor

alan-agius4 commented Aug 14, 2018

@IgorMinar, I have added the requested docs. Can you please review them?

Please feel free to suggest or do any changes.

Ps: I have also rebased and thanks for your review.

@alan-agius4

This comment has been minimized.

Show comment
Hide comment
@alan-agius4

alan-agius4 Aug 14, 2018

Contributor

The Travis failure is a flake.

Contributor

alan-agius4 commented Aug 14, 2018

The Travis failure is a flake.

@benlesh

This comment has been minimized.

Show comment
Hide comment
@benlesh

benlesh Aug 14, 2018

Contributor

@alan-agius4 or @IgorMinar ... flag this as PR action: merge when you're done with your review process, please. I'll keep an eye out.

Contributor

benlesh commented Aug 14, 2018

@alan-agius4 or @IgorMinar ... flag this as PR action: merge when you're done with your review process, please. I'll keep an eye out.

@benlesh

This comment has been minimized.

Show comment
Hide comment
@benlesh

benlesh Aug 14, 2018

Contributor

For googlers: presubmit (attn: @IgorMinar)

Contributor

benlesh commented Aug 14, 2018

For googlers: presubmit (attn: @IgorMinar)

@alan-agius4

This comment has been minimized.

Show comment
Hide comment
@alan-agius4

alan-agius4 Aug 20, 2018

Contributor

@IgorMinar, do you mind re-checking this please? Thanks.

Contributor

alan-agius4 commented Aug 20, 2018

@IgorMinar, do you mind re-checking this please? Thanks.

hasn't replied in 18d

@mary-poppins
@jenniferfell

This comment has been minimized.

Show comment
Hide comment
@jenniferfell

jenniferfell Sep 7, 2018

Contributor

@alan-agius4 Thanks. We've been working on a related doc PR that is also about ready to merge. It contains some improvements to the order of sections within the AOT doc: #22353

I think things will merge more seamlessly if we land 22353 first. I've ask the author to accelerate and she should be done with final changes by EOD today.

Meanwhile, I'll take a look at your new section with an eye toward where it will fit best in the new structure and do a quick copy edit.

Will that work for you?

Contributor

jenniferfell commented Sep 7, 2018

@alan-agius4 Thanks. We've been working on a related doc PR that is also about ready to merge. It contains some improvements to the order of sections within the AOT doc: #22353

I think things will merge more seamlessly if we land 22353 first. I've ask the author to accelerate and she should be done with final changes by EOD today.

Meanwhile, I'll take a look at your new section with an eye toward where it will fit best in the new structure and do a quick copy edit.

Will that work for you?

@alan-agius4

This comment has been minimized.

Show comment
Hide comment
@alan-agius4

alan-agius4 Sep 7, 2018

Contributor
Contributor

alan-agius4 commented Sep 7, 2018

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Sep 10, 2018

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Sep 10, 2018

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Sep 10, 2018

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Sep 11, 2018

feat(compiler-cli): add support to extend `angularCompilerOptions`
`TypeScript` only supports merging and extending of `compilerOptions`. This is an implementation to support extending and inheriting of `angularCompilerOptions` from multiple files.

Closes: #22684
@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Sep 11, 2018

@alan-agius4

This comment has been minimized.

Show comment
Hide comment
@alan-agius4

alan-agius4 Sep 11, 2018

Contributor

@jenniferfell CI is all green here as well

Contributor

alan-agius4 commented Sep 11, 2018

@jenniferfell CI is all green here as well

@IgorMinar

thanks for updating the pr

@IgorMinar

This comment has been minimized.

Show comment
Hide comment

@kara kara closed this in d7e5bbf Sep 19, 2018

@alan-agius4 alan-agius4 deleted the alan-agius4:feature/angular-compiler-opts-extends branch Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment