Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): change ng_package rule to APF v6 #22782

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@alexeagle
Copy link
Contributor

commented Mar 14, 2018

Angular Package Format v6 stops bundling files in the esm5 and esm2015
directories, now that Webpack 4 can tree-shake per-file.

Adds some missing files like package.json to make packages closer to
what we publish today.

Refactor ng_package to be a type of npm_package and re-use the packaging
action from that rule.

@alexeagle alexeagle requested a review from IgorMinar Mar 14, 2018

@googlebot googlebot added the cla: yes label Mar 14, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 14, 2018

@alexeagle alexeagle force-pushed the alexeagle:ng_package branch from ab9382d to 2ae2bf6 Mar 14, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 14, 2018

@alexeagle alexeagle force-pushed the alexeagle:ng_package branch from 2ae2bf6 to c424ff5 Mar 15, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 15, 2018

feat(bazel): change ng_package rule to APF v6
Angular Package Format v6 stops bundling files in the esm5 and esm2015
directories, now that Webpack 4 can tree-shake per-file.

Adds some missing files like package.json to make packages closer to
what we publish today.

Refactor ng_package to be a type of npm_package and re-use the packaging
action from that rule.

@alexeagle alexeagle force-pushed the alexeagle:ng_package branch from c424ff5 to 7bc9ee2 Mar 15, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 15, 2018

# esm5/ and esm2015/ folders.
for f in esm5_sources.to_list():
if f.path.endswith(".js"):
esm5.append(struct(js = f, map = None))

This comment has been minimized.

Copy link
@IgorMinar

IgorMinar Mar 15, 2018

Member

are the source maps inlined in js? that's why no .map files?

This comment has been minimized.

Copy link
@alexeagle

alexeagle Mar 15, 2018

Author Contributor

correct.

@IgorMinar

This comment has been minimized.

Copy link
Member

commented Mar 15, 2018

the ci failure looks like a flake. I restarted the builds.

@alexeagle alexeagle requested review from IgorMinar and removed request for IgorMinar Mar 15, 2018

@mhevery mhevery closed this in 88b3198 Mar 15, 2018

@alexeagle alexeagle deleted the alexeagle:ng_package branch Mar 15, 2018

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

feat(bazel): change ng_package rule to APF v6 (angular#22782)
Angular Package Format v6 stops bundling files in the esm5 and esm2015
directories, now that Webpack 4 can tree-shake per-file.

Adds some missing files like package.json to make packages closer to
what we publish today.

Refactor ng_package to be a type of npm_package and re-use the packaging
action from that rule.

PR Close angular#22782

jmleoni pushed a commit to jmleoni/angular that referenced this pull request Oct 6, 2018

feat(bazel): change ng_package rule to APF v6 (angular#22782)
Angular Package Format v6 stops bundling files in the esm5 and esm2015
directories, now that Webpack 4 can tree-shake per-file.

Adds some missing files like package.json to make packages closer to
what we publish today.

Refactor ng_package to be a type of npm_package and re-use the packaging
action from that rule.

PR Close angular#22782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.