Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mark angular packages as side-effect free #22785

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@IgorMinar
Copy link
Member

commented Mar 15, 2018

This flag is picked up by webpack v4 and used for more agressive optimizations.

Our code is already side-effect free, because that's what we needed for build-optimizer to work.

feat: mark angular packages as side-effect free
This flag is picked up by webpack v4 and used for more agressive optimizations.

Our code is already side-effect free, because that's what we needed for build-optimizer to work.
@mary-poppins

This comment has been minimized.

Copy link

commented Mar 15, 2018

@mhevery mhevery closed this in 44de10e Mar 15, 2018

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

feat: mark angular packages as side-effect free (angular#22785)
This flag is picked up by webpack v4 and used for more agressive optimizations.

Our code is already side-effect free, because that's what we needed for build-optimizer to work.

PR Close angular#22785

jmleoni pushed a commit to jmleoni/angular that referenced this pull request Oct 6, 2018

feat: mark angular packages as side-effect free (angular#22785)
This flag is picked up by webpack v4 and used for more agressive optimizations.

Our code is already side-effect free, because that's what we needed for build-optimizer to work.

PR Close angular#22785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.