Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/apf v6 build.sh #22808

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
4 participants
@IgorMinar
Copy link
Member

commented Mar 15, 2018

No description provided.

@googlebot googlebot added the cla: yes label Mar 15, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 15, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 15, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 15, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 15, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 15, 2018

@IgorMinar IgorMinar force-pushed the IgorMinar:build/apf-v6-build.sh branch from 3ff3cef to a559c82 Mar 15, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 15, 2018

@jasonaden
Copy link
Contributor

left a comment

Looks good. Travis failure.

@IgorMinar IgorMinar force-pushed the IgorMinar:build/apf-v6-build.sh branch from b85a2ec to 37942f1 Mar 16, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 16, 2018

@IgorMinar IgorMinar force-pushed the IgorMinar:build/apf-v6-build.sh branch from 37942f1 to 383bf7e Mar 16, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 16, 2018

@IgorMinar IgorMinar force-pushed the IgorMinar:build/apf-v6-build.sh branch from 383bf7e to ad53a01 Mar 16, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 16, 2018

@IgorMinar

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2018

The PR still fails for two reasons:

  • size regression likely due to some optimization problems when processing the unflattened esm5 input
  • e2e failures from aio examples - this seems to be related to the update of CLI from head (a0fc67002f9578d72de20e626ebdf839ab966571)

@IgorMinar IgorMinar force-pushed the IgorMinar:build/apf-v6-build.sh branch from ad53a01 to 1749954 Mar 16, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 16, 2018

@IgorMinar IgorMinar force-pushed the IgorMinar:build/apf-v6-build.sh branch from 1749954 to e71928f Mar 16, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 16, 2018

"module": "../../fesm5/http/testing.js",
"es2015": "../../fesm2015/http/testing.js",
"esm5": "../../esm5/http/testing.js",
"esm2015": "../../esm2015/http/testing.js"

This comment has been minimized.

Copy link
@IgorMinar

IgorMinar Mar 16, 2018

Author Member

missing fesm5 and fesm2015

@IgorMinar IgorMinar force-pushed the IgorMinar:build/apf-v6-build.sh branch from e71928f to ac402a5 Mar 17, 2018

IgorMinar added some commits Mar 18, 2018

test: improve ng build flags for cli-hello-world
Remove unnecessary --build-optimizer flag and add --sourcemaps flag to
generate source maps for better debugging.
build: don't mark language-service package as sideEffect free
we are not sure if this is the case and we don't need this package to
be optimized at the moment.

@IgorMinar IgorMinar force-pushed the IgorMinar:build/apf-v6-build.sh branch 3 times, most recently from a1c2d13 to d0d5f26 Mar 18, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 18, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 18, 2018

@IgorMinar IgorMinar force-pushed the IgorMinar:build/apf-v6-build.sh branch from d0d5f26 to 0204d71 Mar 18, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 18, 2018

@IgorMinar IgorMinar force-pushed the IgorMinar:build/apf-v6-build.sh branch from 0204d71 to 68bf1d0 Mar 18, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 18, 2018

@IgorMinar IgorMinar force-pushed the IgorMinar:build/apf-v6-build.sh branch from 68bf1d0 to 75df8a8 Mar 18, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 18, 2018

@IgorMinar IgorMinar force-pushed the IgorMinar:build/apf-v6-build.sh branch from 75df8a8 to 0f10c24 Mar 18, 2018

@IgorMinar IgorMinar removed the request for review from alexeagle Mar 18, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 18, 2018

@IgorMinar IgorMinar force-pushed the IgorMinar:build/apf-v6-build.sh branch from 0f10c24 to b688ef8 Mar 18, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 18, 2018

@IgorMinar IgorMinar closed this in 99408d0 Mar 18, 2018

IgorMinar added a commit that referenced this pull request Mar 18, 2018

test: improve ng build flags for cli-hello-world (#22808)
Remove unnecessary --build-optimizer flag and add --sourcemaps flag to
generate source maps for better debugging.

PR Close #22808

IgorMinar added a commit that referenced this pull request Mar 18, 2018

build: don't mark language-service package as sideEffect free (#22808)
we are not sure if this is the case and we don't need this package to
be optimized at the moment.

PR Close #22808

IgorMinar added a commit that referenced this pull request Mar 18, 2018

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

test: improve ng build flags for cli-hello-world (angular#22808)
Remove unnecessary --build-optimizer flag and add --sourcemaps flag to
generate source maps for better debugging.

PR Close angular#22808

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

build: don't mark language-service package as sideEffect free (angula…
…r#22808)

we are not sure if this is the case and we don't need this package to
be optimized at the moment.

PR Close angular#22808

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

jmleoni pushed a commit to jmleoni/angular that referenced this pull request Oct 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.