New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ivy): make sure goog.getMsg()
is defined before being used
#22998
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
'Hello Title!': 'Bonjour Titre!', | ||
}; | ||
window.goog = window.goog || {}; | ||
window.goog.getMsg = (key) => translations[key] || key; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extract all of this to another script tag instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it's your code !
I think it's good enough for now.
You can preview 855e168 at https://pr22998-855e168.ngbuilds.io/. |
You can preview b580b9b at https://pr22998-b580b9b.ngbuilds.io/. |
document.write('<script src="' + | ||
(document.location.search.endsWith('debug') ? '/bundle.min_debug.js' : '/bundle.min.js') + | ||
'"></' + 'script>'); | ||
// `goog.getMsg()` will be provided by Closure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused by the idea that Angular will depend on Closure library. That's not the case, right? If so, update this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, it's only for g3, we haven't coded the service for the community yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Olivier said Angular will depend on Closure compiler for g3. The OSS edition will have an optional dep.
Runtime i18n (and ivy... and other things) are a WIP and will be updated as we make progress.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
supersedes #22996