Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): lower @NgModule ids if needed #23031

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@alxhub
Copy link
Contributor

commented Mar 27, 2018

This change allows the id of an NgModule to be dynamically computed if
needed.

feat(compiler): lower @NgModule ids if needed
This change allows the id of an NgModule to be dynamically computed if
needed.
@ngbot

This comment has been minimized.

Copy link

commented Mar 27, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required status "continuous-integration/travis-ci/pr"
    pending status "ci/circleci: build" is pending
    pending status "ci/circleci: lint" is pending
    pending status "code-review/pullapprove" is pending
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 27, 2018

@alxhub alxhub closed this in bd024c0 Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.