[IVY] "local" compiler #23441

vicb · 2018-04-19T00:06:02Z

No description provided.

mary-poppins · 2018-04-19T00:43:40Z

You can preview 84b2922 at https://pr23441-84b2922.ngbuilds.io/.

mary-poppins · 2018-04-19T02:26:59Z

You can preview 78fb297 at https://pr23441-78fb297.ngbuilds.io/.

mary-poppins · 2018-04-19T18:06:46Z

You can preview bae929b at https://pr23441-bae929b.ngbuilds.io/.

alxhub · 2018-04-19T18:27:23Z

packages/compiler/src/render3/r3_view_compiler_local.ts

+
+    // Match directives on template attributes
+    if (this.directiveMatcher) {
+      const selector = createCssSelector('ng-template', attributeMap);


We should cache these so when parsing different templates we don't re-parse the same selectors.

alxhub · 2018-04-19T18:30:45Z

packages/compiler/test/render3/r3_compiler_compliance_spec.ts

@@ -1156,14 +1156,14 @@ describe('compiler compliance', () => {
            template: function MyComponent_Template(rf: IDENT, ctx: IDENT) {
              if (rf & 1) {
                $r3$.ɵE(0, 'ul');
-                $r3$.ɵC(1, MyComponent_ForOfDirective_Template_1, null, $_c0$);
+                $r3$.ɵC(1, MyComponent_li_Template_1, null, $_c0$);


Could we know that the template came from a *ngFor binding and include that information in the name?

ngbot · 2018-04-19T21:09:20Z

I see that you just added the PR action: merge label, but the following checks are still failing:
     status "ci/circleci: build" is failing
     status "continuous-integration/travis-ci/pr" is failing
     status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

mary-poppins · 2018-04-19T21:24:38Z

You can preview 70f39ed at https://pr23441-70f39ed.ngbuilds.io/.

mary-poppins · 2018-04-19T21:39:26Z

You can preview 31ad139 at https://pr23441-31ad139.ngbuilds.io/.

…tations

closes angular#23289 Based on a spike by @chukjaz

vicb · 2018-04-19T22:48:20Z

http://test/OCL:193572350:BASE:193587591:1524178082713:95eb9775

mary-poppins · 2018-04-19T22:49:08Z

You can preview a017304 at https://pr23441-a017304.ngbuilds.io/.

mary-poppins · 2018-04-19T22:59:23Z

You can preview 20bd15a at https://pr23441-20bd15a.ngbuilds.io/.

vicb · 2018-04-19T23:31:09Z

submitting:

lint is wrong,
pull approve is weird.

PR Close #23441

…23441) closes #23289 Based on a spike by @chukjaz PR Close #23441

angular-automatic-lock-bot · 2019-09-13T15:22:28Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Apr 19, 2018

vicb added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Apr 19, 2018

vicb force-pushed the 0411-ngtsc branch from 646a0ad to f47ba28 Compare April 19, 2018 00:08

This comment has been minimized.

Sign in to view

vicb force-pushed the 0411-ngtsc branch from f47ba28 to 84b2922 Compare April 19, 2018 00:31

vicb force-pushed the 0411-ngtsc branch from 84b2922 to 78fb297 Compare April 19, 2018 02:14

vicb force-pushed the 0411-ngtsc branch from 78fb297 to bae929b Compare April 19, 2018 17:51

alxhub reviewed Apr 19, 2018

View reviewed changes

alxhub approved these changes Apr 19, 2018

View reviewed changes

alxhub self-requested a review April 19, 2018 18:50

alxhub approved these changes Apr 19, 2018

View reviewed changes

vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 19, 2018

vicb force-pushed the 0411-ngtsc branch from bae929b to 70f39ed Compare April 19, 2018 21:11

vicb force-pushed the 0411-ngtsc branch from 70f39ed to 31ad139 Compare April 19, 2018 21:26

vicb added 4 commits April 19, 2018 15:21

feat(compiler): support // ... and // TODO in mock compiler expec…

5b54fef

…tations

refactor(ivy): misc cleanup

8b4ce51

refactor(compiler): misc minor

22ec71f

refactor(ivy): remove the backpatch compiler

0deb21e

vicb force-pushed the 0411-ngtsc branch from 31ad139 to 9b8ab58 Compare April 19, 2018 22:21

vicb force-pushed the 0411-ngtsc branch from 9b8ab58 to a017304 Compare April 19, 2018 22:31

feat(ivy): add an IVY local the compiler which avoids analyzeModule

20bd15a

closes angular#23289 Based on a spike by @chukjaz

vicb force-pushed the 0411-ngtsc branch from a017304 to 20bd15a Compare April 19, 2018 22:46

vicb closed this in c6b206e Apr 19, 2018

vicb added a commit that referenced this pull request Apr 19, 2018

refactor(ivy): misc cleanup (#23441)

84f0243

PR Close #23441

vicb added a commit that referenced this pull request Apr 19, 2018

refactor(compiler): misc minor (#23441)

6ff164b

PR Close #23441

vicb added a commit that referenced this pull request Apr 19, 2018

refactor(ivy): remove the backpatch compiler (#23441)

a19e018

PR Close #23441

vicb added a commit that referenced this pull request Apr 19, 2018

feat(ivy): add an IVY local the compiler which avoids analyzeModule (#…

9757347

…23441) closes #23289 Based on a spike by @chukjaz PR Close #23441

vicb deleted the 0411-ngtsc branch May 14, 2018 22:38

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[IVY] "local" compiler #23441

[IVY] "local" compiler #23441

Uh oh!

vicb commented Apr 19, 2018

Uh oh!

This comment has been minimized.

This comment has been minimized.

mary-poppins commented Apr 19, 2018

Uh oh!

mary-poppins commented Apr 19, 2018

Uh oh!

mary-poppins commented Apr 19, 2018

Uh oh!

alxhub Apr 19, 2018

Uh oh!

alxhub Apr 19, 2018

Uh oh!

ngbot bot commented Apr 19, 2018

Uh oh!

mary-poppins commented Apr 19, 2018

Uh oh!

mary-poppins commented Apr 19, 2018

Uh oh!

vicb commented Apr 19, 2018

Uh oh!

mary-poppins commented Apr 19, 2018

Uh oh!

mary-poppins commented Apr 19, 2018

Uh oh!

vicb commented Apr 19, 2018

Uh oh!

angular-automatic-lock-bot bot commented Sep 13, 2019

Uh oh!

Uh oh!

[IVY] "local" compiler #23441

[IVY] "local" compiler #23441

Uh oh!

Conversation

vicb commented Apr 19, 2018

Uh oh!

This comment has been minimized.

This comment has been minimized.

mary-poppins commented Apr 19, 2018

Uh oh!

mary-poppins commented Apr 19, 2018

Uh oh!

mary-poppins commented Apr 19, 2018

Uh oh!

alxhub Apr 19, 2018

Choose a reason for hiding this comment

Uh oh!

alxhub Apr 19, 2018

Choose a reason for hiding this comment

Uh oh!

ngbot bot commented Apr 19, 2018

Uh oh!

mary-poppins commented Apr 19, 2018

Uh oh!

mary-poppins commented Apr 19, 2018

Uh oh!

vicb commented Apr 19, 2018

Uh oh!

mary-poppins commented Apr 19, 2018

Uh oh!

mary-poppins commented Apr 19, 2018

Uh oh!

vicb commented Apr 19, 2018

Uh oh!

angular-automatic-lock-bot bot commented Sep 13, 2019

Uh oh!

Uh oh!