-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[IVY] "local" compiler #23441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IVY] "local" compiler #23441
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
You can preview 84b2922 at https://pr23441-84b2922.ngbuilds.io/. |
You can preview 78fb297 at https://pr23441-78fb297.ngbuilds.io/. |
You can preview bae929b at https://pr23441-bae929b.ngbuilds.io/. |
|
||
// Match directives on template attributes | ||
if (this.directiveMatcher) { | ||
const selector = createCssSelector('ng-template', attributeMap); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should cache these so when parsing different templates we don't re-parse the same selectors.
@@ -1156,14 +1156,14 @@ describe('compiler compliance', () => { | |||
template: function MyComponent_Template(rf: IDENT, ctx: IDENT) { | |||
if (rf & 1) { | |||
$r3$.ɵE(0, 'ul'); | |||
$r3$.ɵC(1, MyComponent_ForOfDirective_Template_1, null, $_c0$); | |||
$r3$.ɵC(1, MyComponent_li_Template_1, null, $_c0$); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we know that the template came from a *ngFor
binding and include that information in the name?
You can preview 70f39ed at https://pr23441-70f39ed.ngbuilds.io/. |
You can preview 31ad139 at https://pr23441-31ad139.ngbuilds.io/. |
closes angular#23289 Based on a spike by @chukjaz
You can preview a017304 at https://pr23441-a017304.ngbuilds.io/. |
You can preview 20bd15a at https://pr23441-20bd15a.ngbuilds.io/. |
submitting:
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.