Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IVY] "local" compiler #23441

Closed
wants to merge 5 commits into from
Closed

[IVY] "local" compiler #23441

wants to merge 5 commits into from

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Apr 19, 2018

No description provided.

@mary-poppins

This comment has been hidden.

@mary-poppins

This comment has been hidden.

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Apr 19, 2018

Loading

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Apr 19, 2018

Loading

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Apr 19, 2018

Loading


// Match directives on template attributes
if (this.directiveMatcher) {
const selector = createCssSelector('ng-template', attributeMap);
Copy link
Contributor

@alxhub alxhub Apr 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should cache these so when parsing different templates we don't re-parse the same selectors.

Loading

@@ -1156,14 +1156,14 @@ describe('compiler compliance', () => {
template: function MyComponent_Template(rf: IDENT, ctx: IDENT) {
if (rf & 1) {
$r3$.ɵE(0, 'ul');
$r3$.ɵC(1, MyComponent_ForOfDirective_Template_1, null, $_c0$);
$r3$.ɵC(1, MyComponent_li_Template_1, null, $_c0$);
Copy link
Contributor

@alxhub alxhub Apr 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we know that the template came from a *ngFor binding and include that information in the name?

Loading

alxhub
alxhub approved these changes Apr 19, 2018
@alxhub alxhub self-requested a review Apr 19, 2018
alxhub
alxhub approved these changes Apr 19, 2018
@ngbot
Copy link

@ngbot ngbot bot commented Apr 19, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: build" is failing
    failure status "continuous-integration/travis-ci/pr" is failing
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Loading

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Apr 19, 2018

Loading

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Apr 19, 2018

Loading

@vicb
Copy link
Contributor Author

@vicb vicb commented Apr 19, 2018

Loading

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Apr 19, 2018

Loading

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Apr 19, 2018

Loading

@vicb
Copy link
Contributor Author

@vicb vicb commented Apr 19, 2018

submitting:

  • lint is wrong,
  • pull approve is weird.

Loading

@vicb vicb closed this in c6b206e Apr 19, 2018
vicb added a commit that referenced this issue Apr 19, 2018
vicb added a commit that referenced this issue Apr 19, 2018
vicb added a commit that referenced this issue Apr 19, 2018
vicb added a commit that referenced this issue Apr 19, 2018
@vicb vicb deleted the 0411-ngtsc branch May 14, 2018
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Sep 13, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

Loading

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants