Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IVY] "local" compiler #23441

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@vicb
Copy link
Contributor

vicb commented Apr 19, 2018

No description provided.

@mary-poppins

This comment was marked as outdated.

Copy link

mary-poppins commented Apr 19, 2018

@mary-poppins

This comment was marked as outdated.

Copy link

mary-poppins commented Apr 19, 2018

@vicb vicb force-pushed the vicb:0411-ngtsc branch from f47ba28 to 84b2922 Apr 19, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Apr 19, 2018

@vicb vicb force-pushed the vicb:0411-ngtsc branch from 84b2922 to 78fb297 Apr 19, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Apr 19, 2018

@vicb vicb force-pushed the vicb:0411-ngtsc branch from 78fb297 to bae929b Apr 19, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Apr 19, 2018


// Match directives on template attributes
if (this.directiveMatcher) {
const selector = createCssSelector('ng-template', attributeMap);

This comment has been minimized.

@alxhub

alxhub Apr 19, 2018

Contributor

We should cache these so when parsing different templates we don't re-parse the same selectors.

@@ -1156,14 +1156,14 @@ describe('compiler compliance', () => {
template: function MyComponent_Template(rf: IDENT, ctx: IDENT) {
if (rf & 1) {
$r3$.ɵE(0, 'ul');
$r3$.ɵC(1, MyComponent_ForOfDirective_Template_1, null, $_c0$);
$r3$.ɵC(1, MyComponent_li_Template_1, null, $_c0$);

This comment has been minimized.

@alxhub

alxhub Apr 19, 2018

Contributor

Could we know that the template came from a *ngFor binding and include that information in the name?

@alxhub

alxhub approved these changes Apr 19, 2018

@alxhub alxhub self-requested a review Apr 19, 2018

@alxhub

alxhub approved these changes Apr 19, 2018

@ngbot

This comment has been minimized.

Copy link

ngbot bot commented Apr 19, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: build" is failing
    failure status "continuous-integration/travis-ci/pr" is failing
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@vicb vicb force-pushed the vicb:0411-ngtsc branch from bae929b to 70f39ed Apr 19, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Apr 19, 2018

@vicb vicb force-pushed the vicb:0411-ngtsc branch from 70f39ed to 31ad139 Apr 19, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Apr 19, 2018

vicb added some commits Apr 16, 2018

@vicb vicb force-pushed the vicb:0411-ngtsc branch from 31ad139 to 9b8ab58 Apr 19, 2018

@vicb vicb force-pushed the vicb:0411-ngtsc branch from 9b8ab58 to a017304 Apr 19, 2018

@vicb vicb force-pushed the vicb:0411-ngtsc branch from a017304 to 20bd15a Apr 19, 2018

@vicb

This comment has been minimized.

Copy link
Contributor Author

vicb commented Apr 19, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Apr 19, 2018

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Apr 19, 2018

@vicb

This comment has been minimized.

Copy link
Contributor Author

vicb commented Apr 19, 2018

submitting:

  • lint is wrong,
  • pull approve is weird.

@vicb vicb closed this in c6b206e Apr 19, 2018

vicb added a commit that referenced this pull request Apr 19, 2018

vicb added a commit that referenced this pull request Apr 19, 2018

vicb added a commit that referenced this pull request Apr 19, 2018

vicb added a commit that referenced this pull request Apr 19, 2018

@vicb vicb deleted the vicb:0411-ngtsc branch May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.