Skip to content

[IVY] "local" compiler #23441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[IVY] "local" compiler #23441

wants to merge 5 commits into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Apr 19, 2018

No description provided.

@vicb vicb added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Apr 19, 2018
@mary-poppins

This comment has been minimized.

@mary-poppins

This comment has been minimized.

@mary-poppins
Copy link

You can preview 84b2922 at https://pr23441-84b2922.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 78fb297 at https://pr23441-78fb297.ngbuilds.io/.

@mary-poppins
Copy link

You can preview bae929b at https://pr23441-bae929b.ngbuilds.io/.


// Match directives on template attributes
if (this.directiveMatcher) {
const selector = createCssSelector('ng-template', attributeMap);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should cache these so when parsing different templates we don't re-parse the same selectors.

@@ -1156,14 +1156,14 @@ describe('compiler compliance', () => {
template: function MyComponent_Template(rf: IDENT, ctx: IDENT) {
if (rf & 1) {
$r3$.ɵE(0, 'ul');
$r3$.ɵC(1, MyComponent_ForOfDirective_Template_1, null, $_c0$);
$r3$.ɵC(1, MyComponent_li_Template_1, null, $_c0$);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we know that the template came from a *ngFor binding and include that information in the name?

@alxhub alxhub self-requested a review April 19, 2018 18:50
@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 19, 2018
@ngbot
Copy link

ngbot bot commented Apr 19, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: build" is failing
    failure status "continuous-integration/travis-ci/pr" is failing
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mary-poppins
Copy link

You can preview 70f39ed at https://pr23441-70f39ed.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 31ad139 at https://pr23441-31ad139.ngbuilds.io/.

@vicb
Copy link
Contributor Author

vicb commented Apr 19, 2018

@mary-poppins
Copy link

You can preview a017304 at https://pr23441-a017304.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 20bd15a at https://pr23441-20bd15a.ngbuilds.io/.

@vicb
Copy link
Contributor Author

vicb commented Apr 19, 2018

submitting:

  • lint is wrong,
  • pull approve is weird.

@vicb vicb closed this in c6b206e Apr 19, 2018
vicb added a commit that referenced this pull request Apr 19, 2018
vicb added a commit that referenced this pull request Apr 19, 2018
vicb added a commit that referenced this pull request Apr 19, 2018
vicb added a commit that referenced this pull request Apr 19, 2018
@vicb vicb deleted the 0411-ngtsc branch May 14, 2018 22:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants