Skip to content

/angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IVY] "local" compiler #23441

Closed
wants to merge 5 commits into
base: master
from

Conversation

Reviewers

@alxhub alxhub

Assignees
No one assigned
Labels
PR action: merge PR target: master-only cla: yes comp: ivy
Projects
None yet
Milestone
No milestone
4 participants
@vicb @mary-poppins @alxhub @googlebot
@vicb
Copy link
Contributor

vicb commented Apr 19, 2018

No description provided.

@googlebot googlebot added the cla: yes label Apr 19, 2018

@vicb vicb added PR action: review PR target: master-only comp: ivy labels Apr 19, 2018

@vicb vicb force-pushed the vicb:0411-ngtsc branch from 646a0ad to f47ba28 Apr 19, 2018

@mary-poppins

This comment was marked as outdated.

Sign in to view
Copy link

mary-poppins commented Apr 19, 2018

You can preview 646a0ad at https://pr23441-646a0ad.ngbuilds.io/.
@mary-poppins

This comment was marked as outdated.

Sign in to view
Copy link

mary-poppins commented Apr 19, 2018

You can preview f47ba28 at https://pr23441-f47ba28.ngbuilds.io/.

@vicb vicb force-pushed the vicb:0411-ngtsc branch from f47ba28 to 84b2922 Apr 19, 2018

@mary-poppins

This comment has been minimized.

Sign in to view
Copy link

mary-poppins commented Apr 19, 2018

You can preview 84b2922 at https://pr23441-84b2922.ngbuilds.io/.

@vicb vicb force-pushed the vicb:0411-ngtsc branch from 84b2922 to 78fb297 Apr 19, 2018

@mary-poppins

This comment has been minimized.

Sign in to view
Copy link

mary-poppins commented Apr 19, 2018

You can preview 78fb297 at https://pr23441-78fb297.ngbuilds.io/.

@vicb vicb force-pushed the vicb:0411-ngtsc branch from 78fb297 to bae929b Apr 19, 2018

@mary-poppins

This comment has been minimized.

Sign in to view
Copy link

mary-poppins commented Apr 19, 2018

You can preview bae929b at https://pr23441-bae929b.ngbuilds.io/.
@alxhub

alxhub reviewed Apr 19, 2018
View changes

packages/compiler/src/render3/r3_view_compiler_local.ts

// Match directives on template attributes
if (this.directiveMatcher) {
const selector = createCssSelector('ng-template', attributeMap);

This comment has been minimized.

Sign in to view
Copy link
@alxhub

alxhub Apr 19, 2018

Contributor

We should cache these so when parsing different templates we don't re-parse the same selectors.
@alxhub

alxhub reviewed Apr 19, 2018
View changes

packages/compiler/test/render3/r3_compiler_compliance_spec.ts
@@ -1156,14 +1156,14 @@ describe('compiler compliance', () => {
template: function MyComponent_Template(rf: IDENT, ctx: IDENT) {
if (rf & 1) {
$r3$.ɵE(0, 'ul');
$r3$.ɵC(1, MyComponent_ForOfDirective_Template_1, null, $_c0$);
$r3$.ɵC(1, MyComponent_li_Template_1, null, $_c0$);

This comment has been minimized.

Sign in to view
Copy link
@alxhub

alxhub Apr 19, 2018

Contributor

Could we know that the template came from a *ngFor binding and include that information in the name?
@alxhub

alxhub approved these changes Apr 19, 2018
View changes

@alxhub alxhub self-requested a review Apr 19, 2018

@alxhub

alxhub approved these changes Apr 19, 2018
View changes

@vicb vicb added PR action: merge and removed PR action: review labels Apr 19, 2018

@ngbot

This comment has been minimized.

Sign in to view
Copy link

ngbot bot commented Apr 19, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: build" is failing
    failure status "continuous-integration/travis-ci/pr" is failing
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@vicb vicb force-pushed the vicb:0411-ngtsc branch from bae929b to 70f39ed Apr 19, 2018

@mary-poppins

This comment has been minimized.

Sign in to view
Copy link

mary-poppins commented Apr 19, 2018

You can preview 70f39ed at https://pr23441-70f39ed.ngbuilds.io/.

@vicb vicb force-pushed the vicb:0411-ngtsc branch from 70f39ed to 31ad139 Apr 19, 2018

@mary-poppins

This comment has been minimized.

Sign in to view
Copy link

mary-poppins commented Apr 19, 2018

You can preview 31ad139 at https://pr23441-31ad139.ngbuilds.io/.

vicb added some commits Apr 16, 2018

@vicb
feat(compiler): support `// ...` and `// TODO` in mock compiler expec… 
…tations
Verified
This commit was signed with a verified signature.
@vicb vicb Victor Berchet
GPG key ID: 74ACF42B93D98910 Learn about signing commits
Loading status checks…
5b54fef
@vicb
refactor(ivy): misc cleanup
Verified
This commit was signed with a verified signature.
@vicb vicb Victor Berchet
GPG key ID: 74ACF42B93D98910 Learn about signing commits
Loading status checks…
8b4ce51
@vicb
refactor(compiler): misc minor
Verified
This commit was signed with a verified signature.
@vicb vicb Victor Berchet
GPG key ID: 74ACF42B93D98910 Learn about signing commits
Loading status checks…
22ec71f
@vicb
refactor(ivy): remove the backpatch compiler
Verified
This commit was signed with a verified signature.
@vicb vicb Victor Berchet
GPG key ID: 74ACF42B93D98910 Learn about signing commits
Loading status checks…
0deb21e

@vicb vicb force-pushed the vicb:0411-ngtsc branch from 31ad139 to 9b8ab58 Apr 19, 2018

@vicb vicb force-pushed the vicb:0411-ngtsc branch from 9b8ab58 to a017304 Apr 19, 2018

@vicb
feat(ivy): add an IVY local the compiler which avoids analyzeModule 
closes #23289

Based on a spike by @chukjaz
Verified
This commit was signed with a verified signature.
@vicb vicb Victor Berchet
GPG key ID: 74ACF42B93D98910 Learn about signing commits
Loading status checks…
20bd15a

@vicb vicb force-pushed the vicb:0411-ngtsc branch from a017304 to 20bd15a Apr 19, 2018

@vicb

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

vicb commented Apr 19, 2018

http://test/OCL:193572350:BASE:193587591:1524178082713:95eb9775
@mary-poppins

This comment has been minimized.

Sign in to view
Copy link

mary-poppins commented Apr 19, 2018

You can preview a017304 at https://pr23441-a017304.ngbuilds.io/.
@mary-poppins

This comment has been minimized.

Sign in to view
Copy link

mary-poppins commented Apr 19, 2018

You can preview 20bd15a at https://pr23441-20bd15a.ngbuilds.io/.
@vicb

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

vicb commented Apr 19, 2018

submitting:

  • lint is wrong,
  • pull approve is weird.

@vicb vicb closed this in c6b206e Apr 19, 2018

vicb added a commit that referenced this pull request Apr 19, 2018

@vicb
refactor(ivy): misc cleanup (#23441) 
PR Close #23441
84f0243

vicb added a commit that referenced this pull request Apr 19, 2018

@vicb
refactor(compiler): misc minor (#23441) 
PR Close #23441
6ff164b

vicb added a commit that referenced this pull request Apr 19, 2018

@vicb
refactor(ivy): remove the backpatch compiler (#23441) 
PR Close #23441
Loading status checks…
a19e018

vicb added a commit that referenced this pull request Apr 19, 2018

@vicb
feat(ivy): add an IVY local the compiler which avoids analyzeModule (#… 
…23441)

closes #23289

Based on a spike by @chukjaz

PR Close #23441
Loading status checks…
9757347

@vicb vicb deleted the vicb:0411-ngtsc branch May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.