feat(platform-browser): allow lazy-loading HammerJS #23906
Conversation
|
You can preview 950f46f at https://pr23906-950f46f.ngbuilds.io/. |
|
This might be a reasonable case for |
|
@Toxicable the goal is to be agnostic to any particular loading implementation |
|
I’ve been telling people to stop using Promises because Observables are more powerful. I think it would be good to be consistent in the framework side too |
| @@ -58,6 +58,13 @@ const EVENT_NAMES = { | |||
| */ | |||
| export const HAMMER_GESTURE_CONFIG = new InjectionToken<HammerGestureConfig>('HammerGestureConfig'); | |||
|
|
|||
|
|
|||
| /** Function that loads HammerJS, returning a promise that is resolved once HammerJs is loaded. */ | |||
| export type HammerLoader = (() => Promise<void>) | null; | |||
vicb
May 15, 2018
Contributor
Is | null correct here ?
Is | null correct here ?
jelbourn
May 15, 2018
Author
Member
I believe so; null is an acceptable value to provide for the token
I believe so; null is an acceptable value to provide for the token
| @Inject(HAMMER_GESTURE_CONFIG) private _config: HammerGestureConfig, | ||
| private console: Console) { | ||
| @Inject(HAMMER_GESTURE_CONFIG) private _config: HammerGestureConfig, private console: Console, | ||
| @Optional() @Inject(HAMMER_LOADER) private loader?: HammerLoader) { |
vicb
May 15, 2018
Contributor
I think | null should be here instead ?
I think | null should be here instead ?
jelbourn
May 15, 2018
Author
Member
Per other comment: null is an acceptable value to provide for the token
Per other comment: null is an acceptable value to provide for the token
| export type HammerLoader = (() => Promise<void>) | null; | ||
|
|
||
| /** Injection token used to provide a {@link HammerLoader} to Angular. */ | ||
| export const HAMMER_LOADER = new InjectionToken<HammerLoader>('HammerLoader'); |
mhevery
May 16, 2018
Member
You need to add public docs and @stablehere
You need to add public docs and @stablehere
petebacondarwin
May 23, 2018
Member
@stable is no longer needed nor permitted. It is implied from a lack of @deprecated and @experimental tags.
@stable is no longer needed nor permitted. It is implied from a lack of @deprecated and @experimental tags.
|
@jelbourn Is there documentation somewhere to know how to use this feature? Thanks. |
|
No documentation yet, but it boils down to providing a function as |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Open for discussion. I made the loader Promise-based instead of Observable for simplicity here, but can change it if folks feel strongly.