New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): expose a Compiler API for accessing module ids from NgModule types #24258

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@alxhub
Contributor

alxhub commented Jun 1, 2018

This will allow RouterTestingModule to better support lazy loading of modules
when using summaries, since it can detect whether a module is already loaded
if it can access the id.

feat(core): expose a Compiler API for accessing module ids from NgMod…
…ule types

This will allow RouterTestingModule to better support lazy loading of modules
when using summaries, since it can detect whether a module is already loaded
if it can access the id.

@googlebot googlebot added the cla: yes label Jun 1, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Jun 1, 2018

@alxhub alxhub requested a review from IgorMinar Jun 1, 2018

@juliemr

This comment has been minimized.

Member

juliemr commented Jun 1, 2018

This would be great for our router testing purposes!!

@mhevery

mhevery approved these changes Jun 6, 2018

@mhevery mhevery closed this in bd02b27 Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment