Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(animations): do not truncate decimals for delay #24455

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@levgaas
Copy link
Contributor

levgaas commented Jun 12, 2018

Do not truncate decimals for animation delay if specified in seconds

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

When timing has next format: 100ms 0.5s ... applying Math.floor to 0.5 gives us 0 delay. But should be 500

Issue Number: #24291 #23040

What is the new behavior?

100ms 0.5s parsed as:

  • 100ms duration

  • 500ms delay

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

fix(animations): do not truncate decimals for delay
Do not truncate decimals for animation delay if specified in seconds

@googlebot googlebot added the cla: yes label Jun 12, 2018

@levgaas

This comment has been minimized.

Copy link
Contributor Author

levgaas commented Jun 12, 2018

@matsko please, have a look

@matsko

matsko approved these changes Dec 13, 2018

@ngbot ngbot bot added this to the needsTriage milestone Dec 13, 2018

@matsko

This comment has been minimized.

@mhevery

This comment has been minimized.

Copy link
Member

mhevery commented Dec 14, 2018

Please add test

@mhevery mhevery closed this in f1c9d6a Dec 14, 2018

mhevery added a commit that referenced this pull request Dec 14, 2018

fix(animations): do not truncate decimals for delay (#24455)
Do not truncate decimals for animation delay if specified in seconds

PR Close #24455

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

fix(animations): do not truncate decimals for delay (angular#24455)
Do not truncate decimals for animation delay if specified in seconds

PR Close angular#24455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.